Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update check escrow receipt check #629

Merged
merged 2 commits into from
Feb 13, 2025
Merged

refactor: update check escrow receipt check #629

merged 2 commits into from
Feb 13, 2025

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Feb 13, 2025 •
edited
Loading

  • Add denylist pgnotify for horizon tables
  • Update service test to listen to horizon tables
  • Remove typed_builder in favor of bon
  • Rename indexer_monitor::escrow_accounts to indexer_monitor::escrow_accounts_v1
  • Update service router to receive v1 and v2 escrow account watchers
  • Add router creation of escrow account v2 if not provided
  • Update SenderBalanceCheck to route between v1 and v2 accordingly
  • Update sender middleware to use the correct escrow_account monitor

@gusinacio gusinacio marked this pull request as ready for review February 13, 2025 19:01
suchapalaver
suchapalaver approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gusinacio gusinacio merged commit 0817632 into main Feb 13, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/update-tests branch February 13, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchapalaver suchapalaver suchapalaver approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @suchapalaver