test: add rstest and fixtures #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13816278472Details
💛 - Coveralls |
test: revert test fix: tests that fixtures werent available fix: add tokyo to tests style: run cargo clippy
TypeLevelConsoli
requested changes
Mar 12, 2025
crates/service/Cargo.toml
Outdated
| @@ -74,6 +74,7 @@ tokio-test = "0.4.4" | |||
| wiremock.workspace = true | |||
| insta = "1.41.1" | |||
| test-log.workspace = true | |||
| async-std = { version = "1.12.0", features = ["attributes"] } | |||
|
|
|||
There was a problem hiding this comment.
I don't think async-std is necessary, we're using #[tokio::test] on every async test case (same thing for tap-agent)
neithanmo
reviewed
Mar 12, 2025
suchapalaver
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
rstest:rstestthis PR aims to make the tests more easy reading and only focusing on the important bits per test
Due to the nature of async fixtures some tests could use them since the test itself needed to be in some order for it to work as intended.