Disable update of coordinates status log (#5369)

graphql-hive · Aug 13, 2024 · 1eb06c2 · 1eb06c2
1 parent 6ca77ad
commit 1eb06c2
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 50 deletions.
diff --git a/integration-tests/tests/api/schema/cleanup-tracker.spec.ts b/integration-tests/tests/api/schema/cleanup-tracker.spec.ts
@@ -18,7 +18,7 @@ async function fetchCoordinates(db: CommonQueryMethods, target: { id: string })
   return result.rows;
 }
 
-describe('schema cleanup tracker', () => {
+describe.skip('schema cleanup tracker', () => {
   test.concurrent('single', async ({ expect }) => {
     const { publishSchema, target, createDbConnection } = await prepare();
     // This API is soooooooooooo awkward xD

diff --git a/packages/services/storage/src/index.ts b/packages/services/storage/src/index.ts
@@ -5165,66 +5165,70 @@ async function updateSchemaCoordinateStatus(
   const actions: Promise<unknown>[] = [];
 
   if (args.coordinatesDiff.deleted) {
-    actions.push(
-      trx.query(sql`/* schema_coordinate_status_deleted */
-      DELETE FROM schema_coordinate_status
-      WHERE
-        target_id = ${args.targetId}
-        AND
-        coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.deleted), 'text')})
-        AND
-        created_at <= NOW()
-    `),
-    );
+    console.log('DELETED', JSON.stringify(Array.from(args.coordinatesDiff.deleted)));
+    // actions.push(
+    //   trx.query(sql`/* schema_coordinate_status_deleted */
+    //   DELETE FROM schema_coordinate_status
+    //   WHERE
+    //     target_id = ${args.targetId}
+    //     AND
+    //     coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.deleted), 'text')})
+    //     AND
+    //     created_at <= NOW()
+    // `),
+    // );
   }
 
   if (args.coordinatesDiff.added) {
-    actions.push(
-      trx.query(sql`/* schema_coordinate_status_inserted */
-        INSERT INTO schema_coordinate_status
-        ( target_id, coordinate, created_in_version_id, deprecated_at, deprecated_in_version_id )
-        SELECT * FROM ${sql.unnest(
-          Array.from(args.coordinatesDiff.added).map(coordinate => {
-            const isDeprecatedAsWell = args.coordinatesDiff.deprecated.has(coordinate);
-            return [
-              args.targetId,
-              coordinate,
-              args.versionId,
-              // if it's added and deprecated at the same time
-              isDeprecatedAsWell ? 'NOW()' : null,
-              isDeprecatedAsWell ? args.versionId : null,
-            ];
-          }),
-          ['uuid', 'text', 'uuid', 'date', 'uuid'],
-        )}
-      `),
-    );
+    console.log('ADDED', JSON.stringify(Array.from(args.coordinatesDiff.added)));
+    // actions.push(
+    //   trx.query(sql`/* schema_coordinate_status_inserted */
+    //     INSERT INTO schema_coordinate_status
+    //     ( target_id, coordinate, created_in_version_id, deprecated_at, deprecated_in_version_id )
+    //     SELECT * FROM ${sql.unnest(
+    //       Array.from(args.coordinatesDiff.added).map(coordinate => {
+    //         const isDeprecatedAsWell = args.coordinatesDiff.deprecated.has(coordinate);
+    //         return [
+    //           args.targetId,
+    //           coordinate,
+    //           args.versionId,
+    //           // if it's added and deprecated at the same time
+    //           isDeprecatedAsWell ? 'NOW()' : null,
+    //           isDeprecatedAsWell ? args.versionId : null,
+    //         ];
+    //       }),
+    //       ['uuid', 'text', 'uuid', 'date', 'uuid'],
+    //     )}
+    //   `),
+    // );
   }
 
   if (args.coordinatesDiff.undeprecated) {
-    actions.push(
-      trx.query(sql`/* schema_coordinate_status_undeprecated */
-      UPDATE schema_coordinate_status
-      SET deprecated_at = NULL, deprecated_in_version_id = NULL
-      WHERE 
-        target_id = ${args.targetId}
-        AND
-        coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.undeprecated), 'text')})
-    `),
-    );
+    console.log('UNDEPRECATED', JSON.stringify(Array.from(args.coordinatesDiff.undeprecated)));
+    // actions.push(
+    //   trx.query(sql`/* schema_coordinate_status_undeprecated */
+    //   UPDATE schema_coordinate_status
+    //   SET deprecated_at = NULL, deprecated_in_version_id = NULL
+    //   WHERE
+    //     target_id = ${args.targetId}
+    //     AND
+    //     coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.undeprecated), 'text')})
+    // `),
+    // );
   }
 
   await Promise.all(actions);
 
   if (args.coordinatesDiff.deprecated) {
-    await trx.query(sql`/* schema_coordinate_status_deprecated */
-      UPDATE schema_coordinate_status
-      SET deprecated_at = NOW(), deprecated_in_version_id = ${args.versionId}
-      WHERE 
-        target_id = ${args.targetId}
-        AND
-        coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.deprecated), 'text')})
-    `);
+    console.log('DEPRECATED', JSON.stringify(Array.from(args.coordinatesDiff.deprecated)));
+    // await trx.query(sql`/* schema_coordinate_status_deprecated */
+    //   UPDATE schema_coordinate_status
+    //   SET deprecated_at = NOW(), deprecated_in_version_id = ${args.versionId}
+    //   WHERE
+    //     target_id = ${args.targetId}
+    //     AND
+    //     coordinate = ANY(${sql.array(Array.from(args.coordinatesDiff.deprecated), 'text')})
+    // `);
   }
 }