Indicate an initial version in Mutation.schemaCheck (#175)

graphql-hive · Jun 24, 2022 · 482dd42 · 482dd42
1 parent d969ee7
commit 482dd42
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/services/api/src/modules/schema/module.graphql.ts b/packages/services/api/src/modules/schema/module.graphql.ts
@@ -132,6 +132,7 @@ export default gql`
 
   type SchemaCheckSuccess {
     valid: Boolean!
+    initial: Boolean!
     changes: SchemaChangeConnection
   }
 

diff --git a/packages/services/api/src/modules/schema/providers/schema-publisher.ts b/packages/services/api/src/modules/schema/providers/schema-publisher.ts
@@ -81,6 +81,7 @@ export class SchemaPublisher {
     ]);
 
     const schemas = latest.schemas;
+    const isInitialSchema = schemas.length === 0;
 
     await this.tracking.track({
       event: 'SCHEMA_CHECK',
@@ -189,7 +190,10 @@ export class SchemaPublisher {
       }
     }
 
-    return validationResult;
+    return {
+      ...validationResult,
+      initial: isInitialSchema,
+    };
   }
 
   @sentry('SchemaPublisher.publish')

diff --git a/packages/services/api/src/modules/schema/providers/schema-validator.ts b/packages/services/api/src/modules/schema/providers/schema-validator.ts
@@ -70,12 +70,6 @@ export class SchemaValidator {
     const errors = await orchestrator.validate(afterSchemasWithBase);
 
     if (isInitialSchema) {
-      if (errors.length > 0) {
-        errors.push({
-          message: `Note: If this is your first schema publish, please make sure it's fully valid and standalone.`,
-        });
-      }
-
       return {
         valid: errors.length === 0,
         errors: errors,