Add /ecosystem page and migrate to @theguild/components v8 and Nextra 4
#6037
+2,667
−3,526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasparus
force-pushed
the
ecosystem-page
branch
from
e85542d to
645dfc1
Compare
…ot work with Turbopack
hasparus
force-pushed
the
ecosystem-page
branch
from
39f270a to
dcdcf39
Compare
hasparus
force-pushed
the
ecosystem-page
branch
from
e4b8d5f to
221e546
Compare
dimaMachina
reviewed
Dec 10, 2024
dimaMachina
reviewed
Dec 10, 2024
dimaMachina
reviewed
Dec 10, 2024
dimaMachina
reviewed
Dec 10, 2024
| <meta content="en" httpEquiv="Content-Language" /> | ||
| <title>{title}</title> | ||
| <meta name="description" content={description} /> | ||
| <meta property="og:title" content={title} /> |
There was a problem hiding this comment.
Suggested change
| <meta property="og:title" content={title} /> |
we use Next.js Metadata API
dimaMachina
reviewed
Dec 10, 2024
| <link rel="canonical" href={canonicalUrl} /> | ||
| <meta content="en" httpEquiv="Content-Language" /> | ||
| <title>{title}</title> | ||
| <meta name="description" content={description} /> |
There was a problem hiding this comment.
Suggested change
| <meta name="description" content={description} /> |
we use Next.js Metadata API
dimaMachina
reviewed
Dec 10, 2024
dimaMachina
reviewed
Dec 10, 2024
| :root { | ||
| --font-sans: ${neueMontreal.style.fontFamily}; | ||
| } | ||
| :root.dark { |
There was a problem hiding this comment.
Suggested change
| :root.dark { | |
| .dark { |
There was a problem hiding this comment.
Without :root we have lower specificity. I'm not certain removing it won't change everything.
dimaMachina
reviewed
Dec 10, 2024
| --nextra-primary-lightness: 55%; | ||
| --nextra-bg: 17, 17, 17; | ||
| } | ||
| :root.dark *::selection { |
There was a problem hiding this comment.
Suggested change
| :root.dark *::selection { | |
| .dark *::selection { |
dimaMachina
reviewed
Dec 10, 2024
| :root.dark *::selection { | ||
| background-color: hsl(191deg 95% 72% / 0.25) | ||
| } | ||
| :root.light, body.light { |
There was a problem hiding this comment.
Suggested change
| :root.light, body.light { | |
| .light, body.light { |
dimaMachina
reviewed
Dec 10, 2024
dimaMachina
reviewed
Dec 10, 2024
| styles.container, | ||
| )} | ||
| > | ||
| <div className={'flex flex-row ' + styles.vars}> |
There was a problem hiding this comment.
Suggested change
| <div className={'flex flex-row ' + styles.vars}> | |
| <div className={cn('flex', styles.vars)}> |
dimaMachina
reviewed
Dec 10, 2024
| <div> | ||
| <Edge | ||
| top | ||
| className="flex h-[var(--node-h)] flex-row items-center" |
There was a problem hiding this comment.
Suggested change
| className="flex h-[var(--node-h)] flex-row items-center" | |
| className="flex h-[--node-h] items-center" |
dimaMachina
reviewed
Dec 10, 2024
| <EdgeLabel onPointerOver={onPointerOverEdge}>1</EdgeLabel> | ||
| <div className="w-[calc(var(--label-h)/1.6)]" /> | ||
| </Edge> | ||
| <div className="h-[var(--gap)]" /> |
There was a problem hiding this comment.
Suggested change
| <div className="h-[var(--gap)]" /> | |
| <div className="h-[--gap]" /> |
dimaMachina
reviewed
Dec 10, 2024
| <Edge | ||
| top | ||
| highlighted={highlightedEdge === 3} | ||
| className="flex h-[var(--big-node-h)] flex-row items-center" |
There was a problem hiding this comment.
Suggested change
| className="flex h-[var(--big-node-h)] flex-row items-center" | |
| className="flex h-[--big-node-h] items-center" |
dimaMachina
reviewed
Dec 10, 2024
Comment on lines
331
to
333
| 'relative z-10 flex h-[--node-h] items-center gap-2 rounded-2xl p-4 xl:gap-4 xl:p-[22px]' + | ||
| ' bg-[linear-gradient(135deg,rgb(255_255_255/0.10),rgb(255_255_255/0.20))]' + | ||
| ' cursor-pointer transition-colors duration-500 [&>svg]:flex-shrink-0', |
There was a problem hiding this comment.
Suggested change
| 'relative z-10 flex h-[--node-h] items-center gap-2 rounded-2xl p-4 xl:gap-4 xl:p-[22px]' + | |
| ' bg-[linear-gradient(135deg,rgb(255_255_255/0.10),rgb(255_255_255/0.20))]' + | |
| ' cursor-pointer transition-colors duration-500 [&>svg]:flex-shrink-0', | |
| 'relative z-10 flex h-[--node-h] items-center gap-2 rounded-2xl p-4 xl:gap-4 xl:p-[22px]', | |
| 'bg-[linear-gradient(135deg,rgb(255_255_255/0.10),rgb(255_255_255/0.20))]', | |
| 'cursor-pointer transition-colors duration-500 [&>svg]:flex-shrink-0', |
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Piotr Monwid-Olechnowicz <[email protected]>
hasparus
commented
Dec 13, 2024
| const args = parseArgs({ | ||
| options: { | ||
| cwd: { type: 'string', default: process.cwd() }, | ||
| files: { type: 'string', default: 'src/content/**/*.mdx' }, |
There was a problem hiding this comment.
Suggested change
| files: { type: 'string', default: 'src/content/**/*.mdx' }, | |
| files: { type: 'string', default: 'src/**/*.mdx' }, |
@dimaMachina I'm changing it to grab components and pages dir too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I'll admit I thought the migration will go faster and that's why those two things are in the same PR.
Description
What's changed
/ecosystempage.@theguild/componentsand by extension Nextra 4.Checklist