Updating to v22 #95
Merged
Updating to v22 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Apr 7, 2024
| @@ -34,15 +36,23 @@ public ValidationSchemaWiring(ValidationRules ruleCandidates) { | |||
| public GraphQLFieldDefinition onField(SchemaDirectiveWiringEnvironment<GraphQLFieldDefinition> env) { | |||
| GraphQLFieldsContainer fieldsContainer = env.getFieldsContainer(); | |||
| GraphQLFieldDefinition fieldDefinition = env.getFieldDefinition(); | |||
|
|
|||
| TargetedValidationRules rules = ruleCandidates.buildRulesFor(fieldDefinition, fieldsContainer); | |||
| if (rules.isEmpty()) { | |||
There was a problem hiding this comment.
This should always have been present. Dont build a new DataFetcher unless there is rules for that field
I am not sure how this got missed
bbakerman
commented
Apr 7, 2024
| if (! (fieldsContainer instanceof GraphQLObjectType)) { | ||
| // only object type fields can have data fetchers | ||
| return fieldDefinition; | ||
| } |
There was a problem hiding this comment.
The new version of grpahql-java 22 does not allow setting a data fetcher on GraphQLFieldsContainer anymore since that's nonsensical for interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a staging PR for when v22 of graphql-java is made available