Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the argument of the gql function #435

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Sep 9, 2023

If you accidentally call gql with a value that is already the result of a gql call, you get an error message that is not very helpful.

This PR improves the error message and also allows passing a graphql Source object instead of a string.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d4c9751) 100.00% compared to head (6ef52b2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2492      2497    +5     
=========================================
+ Hits          2492      2497    +5     
Files Changed Coverage Δ
gql/gql.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leszekhanusz leszekhanusz merged commit dfbcb59 into graphql-python:master Sep 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants