Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New transport AIOHTTPWebsocketsTransport #478

Merged
merged 64 commits into from
Jul 25, 2024
Merged

New transport AIOHTTPWebsocketsTransport #478

merged 64 commits into from
Jul 25, 2024

Commits on May 7, 2024

  1. expose all ws_connect arguments

    Taylor Lowery committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c0b429b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. wip: mirrroring websockets_base interface in aiohttp_websockets

    Taylor Lowery committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c875fd8 View commit details
    Browse the repository at this point in the history

  2. black format

    Taylor Lowery committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1117d3a View commit details
    Browse the repository at this point in the history

  3. wip: add more methods in pursuit of parity

    Taylor Lowery committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f3a927c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. WIP: aiohttp websockets parity

    Micah Pegman committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7378a53 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. answer improvements 

    Signed-off-by: Micah Pegman <[email protected]>
    Micah Pegman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1c8eda5 View commit details
    Browse the repository at this point in the history

  2. linting fixes 

    Signed-off-by: Micah Pegman <[email protected]>
    @mpegman-scwx
    mpegman-scwx committed May 30, 2024
    Configuration menu
    Copy the full SHA
    34fc580 View commit details
    Browse the repository at this point in the history

  3. wip: initial tests

    Taylor Lowery committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f5d208c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'aiohttp_websockets' of https://github.com/tlowery-scwx/gql 

     into aiohttp_websockets
    Taylor Lowery committed May 30, 2024
    Configuration menu
    Copy the full SHA
    aa50d20 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. wip: initial tests for aiohttp websockets

    Taylor Lowery committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b44fd45 View commit details
    Browse the repository at this point in the history

  2. fix some minor import errors

    Taylor Lowery committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f438531 View commit details
    Browse the repository at this point in the history

  3. fix incorrect fixture

    Taylor Lowery committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8f44fc6 View commit details
    Browse the repository at this point in the history

  4. update query tests to match AIOHTTPWebsocketsTransport behavior

    Taylor Lowery committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ef84507 View commit details
    Browse the repository at this point in the history

  5. wip: updating tests to follow AIOHTTPWebsockets protocol

    Taylor Lowery committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9870336 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. remove unnecessary websockets imports

    Taylor Lowery committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6584f54 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. fix some tests

    @mpegman-scwx
    mpegman-scwx committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fc73ba1 View commit details
    Browse the repository at this point in the history

  2. more test fixes 

    Signed-off-by: Micah Pegman <[email protected]>
    @mpegman-scwx
    mpegman-scwx committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e4dbce8 View commit details
    Browse the repository at this point in the history

  3. add ci test job for aiohttp_websockets

    Taylor Lowery committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e47ce3b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. add aiohttp websocket tests for graphql websockets

    Taylor Lowery committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cd71e91 View commit details
    Browse the repository at this point in the history

  2. update tests to AIOHTTPWebsocketsTransport

    Taylor Lowery committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    bbddf25 View commit details
    Browse the repository at this point in the history

  3. add missing import

    Taylor Lowery committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    252969e View commit details
    Browse the repository at this point in the history

  4. set exceptions tests to expect the correct errors

    Taylor Lowery committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1b729c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. test updates 

    Signed-off-by: Micah Pegman <[email protected]>
    @mpegman-scwx
    mpegman-scwx committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3d99402 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. get response headers from aiohttp client response

    Taylor Lowery committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    10e2172 View commit details
    Browse the repository at this point in the history

  2. transport feature updates 

    Signed-off-by: Micah Pegman <[email protected]>
    @mpegman-scwx
    mpegman-scwx committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3bd3126 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. increase test coverage over edge cases

    Taylor Lowery committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2ad42ab View commit details
    Browse the repository at this point in the history

  2. ran formatter

    Taylor Lowery committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e5770c7 View commit details
    Browse the repository at this point in the history

  3. remove unused import

    Taylor Lowery committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f28c4fe View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. remove unnecessary timeout

    Taylor Lowery committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2b25cb8 View commit details
    Browse the repository at this point in the history

  2. remove hanging test

    Taylor Lowery committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b158614 View commit details
    Browse the repository at this point in the history

  3. re-add hanging test with skip marker and explanation

    Taylor Lowery committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bae308f View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Modify _receive method to be more like the websockets one

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    5acb518 View commit details
    Browse the repository at this point in the history

  2. Running make check

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    4ec2516 View commit details
    Browse the repository at this point in the history

  3. Revert all code changes outside of the scope of this PR

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    6336eaa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into aiohttp_websockets

    @leszekhanusz
    leszekhanusz authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    b6163c0 View commit details
    Browse the repository at this point in the history

  5. Fix aiohttp_websocket ssl attribute typing

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0736dc0 View commit details
    Browse the repository at this point in the history

  6. Revert all code changes outside of the scope of this PR - 2

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    172d65d View commit details
    Browse the repository at this point in the history

  7. Remove invalid aiohttp_websockets dependency from github workflow

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    5653d56 View commit details
    Browse the repository at this point in the history

  8. Add the aiohttp AND websockets mark to the aiohttp_websocket tests

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    f1fb25d View commit details
    Browse the repository at this point in the history

  9. Copy ListenerQueue in aiohttp_websockets.py 

    It is necessary to avoid needing the websockets dependency when using the AIOHTTPWebsockets transport
    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    3a762ae View commit details
    Browse the repository at this point in the history

  10. Fix importing Literal for Python 3.7

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    fcd59dc View commit details
    Browse the repository at this point in the history

  11. assertion instead of TransportClosed exception if websocket is None

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    64d6ffd View commit details
    Browse the repository at this point in the history

  12. small cleaning

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    87b5573 View commit details
    Browse the repository at this point in the history

  13. Close aiohttp session properly, inspired from aiohttp transport

    @leszekhanusz
    leszekhanusz committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    270d8ec View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Add test for ssl_close_timeout parameter

    @leszekhanusz
    leszekhanusz committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    ddcc77f View commit details
    Browse the repository at this point in the history

  2. Add test for client_session_args and connector_owner_false

    @leszekhanusz
    leszekhanusz committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    05e61b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into aiohttp_websockets

    @leszekhanusz
    leszekhanusz authored Jul 14, 2024
    Configuration menu
    Copy the full SHA
    5e0beb2 View commit details
    Browse the repository at this point in the history

  4. Fix handling of connection_error during init

    @leszekhanusz
    leszekhanusz committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    2af7d40 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Fix RuntimeError event loop is closed exception shown during tests

    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b529ea2 View commit details
    Browse the repository at this point in the history

  2. Revert "assertion instead of TransportClosed exception if websocket i… 

    …s None"

This reverts commit 64d6ffd.
    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    170846f View commit details
    Browse the repository at this point in the history

  3. Using _wait_closed.is_set() to determine if we need to wait or close … 

    …the transport
    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9a10f0d View commit details
    Browse the repository at this point in the history

  4. Ignore low-level ping pong messages

    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4aaf86a View commit details
    Browse the repository at this point in the history

  5. Rename timeout to websocket_close_timeout, reorder init params

    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    277fd5d View commit details
    Browse the repository at this point in the history

  6. Modify transport init parameters 

    Adding connect_args parameter to be able to provide any argument to the ws_connect method

Removing the following parameters (they can now be provided in the connect_args dict):
 - autoclose
 - autoping
 - compress
 - max_msg_size
 - verify_ssl
 - method

Renaming protocols to subprotocols to be more similar to the websockets transport
    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a8b276d View commit details
    Browse the repository at this point in the history

  7. Use connect_timeout param

    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6906ad2 View commit details
    Browse the repository at this point in the history

  8. Add reference documentation + remove deprecated ssl_context param

    @leszekhanusz
    leszekhanusz committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4ea698f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Allow to use the new transport from the cli

    @leszekhanusz
    leszekhanusz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    97ac985 View commit details
    Browse the repository at this point in the history

  2. Adding a new ws test server using aiohttp to do some tests without we… 

    …bsockets
    @leszekhanusz
    leszekhanusz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    cfee44c View commit details
    Browse the repository at this point in the history

  3. Try to fix ConnectionResetError exception

    @leszekhanusz
    leszekhanusz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d43224f View commit details
    Browse the repository at this point in the history

  4. Fix anext not existing on Python 3.8

    @leszekhanusz
    leszekhanusz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    04cd47c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Adding the transport to the docs

    @leszekhanusz
    leszekhanusz committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    933348d View commit details
    Browse the repository at this point in the history

  2. Fix tests still using WebsocketsTransport instead of new transport

    @leszekhanusz
    leszekhanusz committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    22e8a3a View commit details
    Browse the repository at this point in the history

  3. Fix countdown server not closing properly in some cases

    @leszekhanusz
    leszekhanusz committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    db9f5db View commit details
    Browse the repository at this point in the history

  4. More resilient _close_coro cleanup

    @leszekhanusz
    leszekhanusz committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9eaafa4 View commit details
    Browse the repository at this point in the history