polish(Queue): further simplify algorithm #4501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
further simplify Queue algorithm at the expense of potentially a few extra micro-tasks (which leads to further coalescing/batching of results, actually a side-benefit).
yaacovCR
added
the
PR: polish 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=> further simplifies Queue algorithm at the expense of (potentially) a few extra micro-tasks.
The extra micro-tasks actually may lead to a few extra items being batched depending on the exact nature of the executor, potentially an added side-benefit.
Within our GraphQL code, there are no test changes, as the Queue executor just saves the push/stop methods and passes them to the IncrementalGraph.