This repository was archived by the owner on Sep 2, 2020. It is now read-only.
[EXPERIMENTAL] - support inputUnion #351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
commented
Apr 5, 2019
| word('inputUnion'), | ||
| name('atom'), | ||
| list('Directive'), | ||
| p('='), |
There was a problem hiding this comment.
i think we need the optional default keyword here as well?
acao
changed the title
acao
commented
Apr 5, 2019
| @@ -196,6 +198,7 @@ export const ParseRules: {[name: string]: ParseRule} = { | |||
| Type(token: Token) { | |||
| return token.value === '[' ? 'ListType' : 'NonNullType'; | |||
| }, | |||
| InputUnionValue: [p('{'), list('ObjectField'), p('}')], | |||
There was a problem hiding this comment.
I couldn't figure out how to get Value to return this in the case statement above, but maybe that's because I never saw a kind for it?
acao
changed the title
|
This is where I'm at now, seems close |
|
@asiandrummer @AGS- @wincent thoughts? |
|
Ah ha! It was true that |
|
This has come a long way since yesterday. Moved discussion to the |
|
save this one for posterity! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to be used with graphql/graphql-js#1196
Pending: matching PRs for
graphql-configgraphql-importand@types/graphql