Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow #185

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Adding workflow #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3aae06d
adding workflow + fixing eslint issues
gagoar Nov 17, 2020
4f60ccc
running tests only
gagoar Nov 17, 2020
88dadea
pull/push/g
gagoar Nov 17, 2020
9a822c2
removing token from codecov
gagoar Nov 18, 2020
04c1e80
removing travis config
gagoar Nov 18, 2020
ebbfdf4
adding bahmutov/npm-install to workflow
gagoar Nov 20, 2020
8c37cb9
missing name
gagoar Nov 20, 2020
8eb6d79
Simplifying jobs
gagoar Nov 23, 2020
f8f8bed
adding cache
gagoar Nov 25, 2020
6c07d45
adding pull request event
gagoar Nov 25, 2020
6620104
avoiding pull_request event because is duplicated
gagoar Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Lint and Tests

on: push

jobs:
validation:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Use Node.js 12.x
uses: actions/setup-node@v1
with:
node-version: 12.x
- name: Cache Node.js modules
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.OS }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.OS }}-node-
- name: Install dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bahmutov/npm-install this provides some better cacheing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is official cache action:
https://github.com/graphql/graphql-js/blob/cd273ad136d615b3f2f4c830bd8891c7c5590c30/.github/workflows/ci.yml#L18-L24
I think we should minimize the number of 3rd-party dependencies especially since this particular one is not very popular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

run: npm install
- name: Lint
run: npm run lint
- name: Tests
run: npm run test:only
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
with:
fail_ci_if_error: true
5 changes: 0 additions & 5 deletions .travis.yml
View file
Open in desktop

This file was deleted.