Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch stacked labels #204

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Ch stacked labels #204

wants to merge 13 commits into from

Conversation

raisin-toast
Copy link
Contributor

Add ch_stacked_labels to make it easier to make pretty labels

@MattCowgill
Copy link
Contributor

@wfmackey 👀

@raisin-toast
Copy link
Contributor Author

@wfmackey 👀

This is similar to your package Matt - just the implementation my old team used haha

@MattCowgill
Copy link
Contributor

ah yep @raisin-toast. I think we've gone in different directions a bit, in that my function is a geom (geom_finallabel()) that you add to a plot as you're constructing it, whereas yours looks like something that you provide an assembled plot to?

I wasn't sure what chart_citymapper() was in the example

@raisin-toast
Copy link
Contributor Author

ah yep @raisin-toast. I think we've gone in different directions a bit, in that my function is a geom (geom_finallabel()) that you add to a plot as you're constructing it, whereas yours looks like something that you provide an assembled plot to?

I wasn't sure what chart_citymapper() was in the example

Yeah you pipe it in because it automatically adds some expansion to your charts so that the labels can fit. Which is pretty nifty.

Also finally got around to fixing the documentation lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants