Skip to content

Commit

Permalink
Fix skipped but required checks for Github Actions (#19594)
Browse files Browse the repository at this point in the history
  • Loading branch information
r0mant authored Dec 22, 2022
1 parent 44715e1 commit f873cbe
Show file tree
Hide file tree
Showing 14 changed files with 19 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-macos-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:

jobs:
build:
name: Skipped
name: Build on Mac OS
runs-on: macos-12

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:

jobs:
build:
name: Build all tools on Mac OS
name: Build on Mac OS
runs-on: macos-12 # TODO(r0mant): Update with large runner when it's available

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-windows-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:

jobs:
build:
name: Skipped
name: Build on Windows
runs-on: windows-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
build:
name: Build tsh tool on Windows
name: Build on Windows
runs-on: windows-2022-16core

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-non-root-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:

jobs:
test:
name: Skipped
name: Integration Tests (Non-root)
runs-on: ubuntu-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-root-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:

jobs:
test:
name: Skipped
name: Integration Tests (Root)
runs-on: ubuntu-latest

permissions:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/os-compatibility-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build:
name: Build Artifacts
name: OS Compatibility Build
runs-on: ubuntu-22.04-16core

permissions:
Expand All @@ -28,7 +28,7 @@ jobs:

- name: Run make
run: |
make build/tctl build/tsh build/tbot build/teleport
make binaries
- name: Upload binaries
uses: actions/upload-artifact@v3
Expand All @@ -38,7 +38,7 @@ jobs:

test-compat:
needs: build
name: Run Compatibility Test
name: OS Compatibility Test
runs-on: ubuntu-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-code-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

jobs:
test:
name: Skipped
name: Unit Tests (Go)
runs-on: ubuntu-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-helm-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

jobs:
test:
name: Skipped
name: Unit Tests (Helm)
runs-on: ubuntu-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-operator-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:

jobs:
test:
name: Skipped
name: Unit Tests (Operator)
runs-on: ubuntu-latest

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-rust-bypass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:

jobs:
test:
name: Skipped
name: Unit Tests (Rust)
runs-on: ubuntu-latest

permissions:
Expand Down
3 changes: 2 additions & 1 deletion api/client/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ func DialProxy(ctx context.Context, proxyURL *url.URL, addr string) (net.Conn, e
return DialProxyWithDialer(ctx, proxyURL, addr, &net.Dialer{})
}

// DialProxyWithDialer creates a connection to a server via an HTTP or SOCKS5 Proxy using a specified dialer.
// DialProxyWithDialer creates a connection to a server via an HTTP or SOCKS5
// Proxy using a specified dialer.
func DialProxyWithDialer(
ctx context.Context,
proxyURL *url.URL,
Expand Down
4 changes: 2 additions & 2 deletions api/types/authority.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import (
"github.com/gravitational/teleport/api/constants"
)

// CertAuthority is a host or user certificate authority that
// can check and if it has private key stored as well, sign it too
// CertAuthority is a host or user certificate authority that can check and if
// it has private key stored as well, sign it too.
type CertAuthority interface {
// ResourceWithSecrets sets common resource properties
ResourceWithSecrets
Expand Down
4 changes: 2 additions & 2 deletions lib/srv/desktop/rdp/rdpclient/src/piv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ pub struct Card<const S: usize> {
piv_auth_cert: Vec<u8>,
piv_auth_key: RsaPrivateKey,
pin: String,
// Pending command and response to receive/send over multiple messages when they don't fit into
// one.
// Pending command and response to receive/send over multiple messages when
// they don't fit into one.
pending_command: Option<Command<S>>,
pending_response: Option<Cursor<Vec<u8>>>,
}
Expand Down

0 comments on commit f873cbe

Please sign in to comment.