-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiscoveryConfigStatus AWS EC2 resource counters (proto) #45553
Merged
marcoandredinis
merged 2 commits into
master
from
marco/discoveryconfigstatus_aws_counters_proto
Aug 27, 2024
Merged
Add DiscoveryConfigStatus AWS EC2 resource counters (proto) #45553
marcoandredinis
merged 2 commits into
master
from
marco/discoveryconfigstatus_aws_counters_proto
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
discover
Issues related to Teleport Discover
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
labels
Aug 16, 2024
marcoandredinis
force-pushed
the
marco/discoveryconfigstatus_aws_counters_proto
branch
from
August 20, 2024 10:19
a1571f3
to
fc2499b
Compare
marcoandredinis
changed the title
Add DiscoveryConfigStatus AWS resource counters (proto)
Add DiscoveryConfigStatus AWS EC2 instance counters counters (proto)
Aug 20, 2024
marcoandredinis
changed the title
Add DiscoveryConfigStatus AWS EC2 instance counters counters (proto)
Add DiscoveryConfigStatus AWS EC2 resource counters (proto)
Aug 20, 2024
marcoandredinis
force-pushed
the
marco/discoveryconfigstatus_aws_counters_proto
branch
from
August 20, 2024 13:32
fc2499b
to
630f4a4
Compare
marcoandredinis
force-pushed
the
marco/discoveryconfigstatus_aws_counters_proto
branch
2 times, most recently
from
August 23, 2024 09:24
fb7668a
to
2905c17
Compare
Friendly ping @kiosion @timothyb89 |
kiosion
approved these changes
Aug 24, 2024
Joerger
approved these changes
Aug 26, 2024
This PR adds counters for AWS Instances found/enrolled/failed for a given DiscoveryConfig and Integration.
marcoandredinis
force-pushed
the
marco/discoveryconfigstatus_aws_counters_proto
branch
2 times, most recently
from
August 27, 2024 09:51
48618e2
to
4c93489
Compare
marcoandredinis
force-pushed
the
marco/discoveryconfigstatus_aws_counters_proto
branch
from
August 27, 2024 09:59
4c93489
to
0495278
Compare
tigrato
approved these changes
Aug 27, 2024
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
August 27, 2024 13:08
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 27, 2024
marcoandredinis
deleted the
marco/discoveryconfigstatus_aws_counters_proto
branch
August 27, 2024 13:39
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Aug 27, 2024
* Add DiscoveryConfigStatus AWS EC2 resource counters (proto) This PR adds counters for AWS Instances found/enrolled/failed for a given DiscoveryConfig and Integration. * use a map to index on the integration name
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…45903) * Add DiscoveryConfigStatus AWS EC2 resource counters (proto) This PR adds counters for AWS Instances found/enrolled/failed for a given DiscoveryConfig and Integration. * use a map to index on the integration name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
discover
Issues related to Teleport Discover
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds counters for AWS Instances found/enrolled/failed for a given DiscoveryConfig and Integration.
Context: #41909