Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Decision (aka PDP) protos #49875

Merged
merged 20 commits into from
Dec 16, 2024
Merged

Conversation

codingllama
Copy link
Contributor

Initial set of protos for the DecisionService (aka PDP or Policy Decision Point). Subject to change, but committed now so we can build the basic skaffolding for the service in small steps.

Definitions follow #49132 (with a few tweaks and changes here and there).

#49837

Co-authored-by: Forrest [email protected]

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 6, 2024
@github-actions github-actions bot requested review from nklaassen and rudream December 6, 2024 14:42
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49875.d3pp5qlev8mo18.amplifyapp.com

@codingllama
Copy link
Contributor Author

(Note: I'll squash all the "Update generated protos" commits once the review is done.)

@codingllama
Copy link
Contributor Author

PTAL @rosstimothy.

@codingllama
Copy link
Contributor Author

Friendly ping @rosstimothy @nklaassen @rudream

@rosstimothy
Copy link
Contributor

I suspect there might need to be some alterations to these protos to account for the feedback that Tiago left on the RFD.

@codingllama
Copy link
Contributor Author

I suspect there might need to be some alterations to these protos to account for the feedback that Tiago left on the RFD.

I've read/replied to some of Tiago's feedback, but I don't think it needs to block approval from this PR. Worst case scenario we will adapt the definitions, but this lets us progress in the meantime.

As noted in the PR description the protos here are subject to change (and the breaking linter is disabled for now).

@codingllama
Copy link
Contributor Author

Friendly ping @rosstimothy @fspmarshall.

@codingllama
Copy link
Contributor Author

Friendly ping @rosstimothy.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream December 16, 2024 17:58
@codingllama codingllama added this pull request to the merge queue Dec 16, 2024
@codingllama
Copy link
Contributor Author

Thanks, queued!

Merged via the queue into master with commit ec2d05f Dec 16, 2024
44 checks passed
@codingllama codingllama deleted the codingllama/pdp-protos branch December 16, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants