[v15] Filter while paging in GetByVMID #50000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates GetByVMID, used by azure joining, to filter by id for each page of vms instead of filtering after accumulating _all_ vms in memory first. While this does reduce memory consumption, the listing process is still suboptimal in that _all_ instances in a subscription are retrieved in response to _every_ join request.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
marcoandredinis
approved these changes
Dec 10, 2024
zmb3
approved these changes
Dec 10, 2024
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49968 to branch/v15
changelog: Reduce Auth memory consumption when agents join using the azure join method.