Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] chore: Bump golang.org/x/crypto to v0.31.0 #50081

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

codingllama
Copy link
Contributor

Backport #50075 to branch/v14.

Changelog: Updated golang.org/x/crypto to v0.31.0 (CVE-2024-45337)

Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a separate update to the plugins?

@codingllama
Copy link
Contributor Author

Does this need a separate update to the plugins?

Do the plugins actually care about /x/crypto/ssh?

@rosstimothy
Copy link
Contributor

Do the plugins actually care about /x/crypto/ssh?

They use ssh to connect to the cluster 🙃

@codingllama
Copy link
Contributor Author

Do the plugins actually care about /x/crypto/ssh?

They use ssh to connect to the cluster 🙃

If they don't serve connections I don't think they care. In any case it would be good to update to pacify security scanners. FYI @hugoShaka.

@rosstimothy
Copy link
Contributor

In any case it would be good to update to pacify security scanners

Yeah that was exactly why I asked.

@hugoShaka
Copy link
Contributor

hugoShaka commented Dec 11, 2024

If they don't serve connections I don't think they care.

Yeah, plugins should not be vulnerable as they don't run SSH servers.

In any case it would be good to update to pacify security scanners.

I think the repo plugin is now archived? Prior to the plugin repo merge, we never supported backport and bugfixes to older plugin versions (plugins release mechanism always used the last stable teleport release).

Since the teleport-plugins -> teleport repo merge we do plugin backports the same way we do regular teleport backports. However this doe snot apply to pre-merge plugin versions which are still subject to the old release strategy (no release for older major versions).

@codingllama codingllama added this pull request to the merge queue Dec 12, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from espadolini December 12, 2024 14:08
Merged via the queue into branch/v14 with commit a998cd9 Dec 12, 2024
30 checks passed
@codingllama codingllama deleted the codingllama/bump-x-crypto-v14 branch December 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants