Cache Kubernetes App Discovery port check results #50286
+125
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
gabrielcorado
approved these changes
Dec 16, 2024
rosstimothy
reviewed
Dec 16, 2024
marcoandredinis
force-pushed
the
marco/cache_kubeappdiscovery_protocol
branch
from
341a968 to
4016d08
Compare
For the K8S Services that we couldn't auto detect the protocol, after trying to infer the port, cache the result. Cache is evicted when the K8S Service changes (we check the Service's ResourceVersion).
marcoandredinis
force-pushed
the
marco/cache_kubeappdiscovery_protocol
branch
from
4016d08 to
e7a8705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the K8S Services that we couldn't auto detect the protocol, after trying to infer the port, cache the result.
Cache is evicted when the K8S Service changes (we check the Service's ResourceVersion).