-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine ID: Support path-based Kubernetes routing #50898
Open
timothyb89
wants to merge
8
commits into
timothyb89/kubernetes-path-routing
Choose a base branch
from
timothyb89/kubernetes-path-routing-tbot
base: timothyb89/kubernetes-path-routing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Machine ID: Support path-based Kubernetes routing #50898
timothyb89
wants to merge
8
commits into
timothyb89/kubernetes-path-routing
from
timothyb89/kubernetes-path-routing-tbot
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
timothyb89
force-pushed
the
timothyb89/kubernetes-path-routing-tbot
branch
from
January 14, 2025 03:59
c5e81d3
to
eef0afc
Compare
strideynet
reviewed
Jan 14, 2025
This adds a new `kubernetes/v2` service to support path-based routing, which allows clients to access an arbitrary number of Kubernetes clusters using a single issued identity. It can be used with `tbot start kubernetes/v2` and specifying one or more explicit clusters with `--kubernetes-cluster-name` or a label selector with `--kubernetes-cluster-labels`.
timothyb89
force-pushed
the
timothyb89/kubernetes-path-routing-tbot
branch
from
January 17, 2025 03:17
eef0afc
to
a1b84c0
Compare
strideynet
reviewed
Jan 17, 2025
strideynet
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I'll approve here but let's make sure we come to a decision on the roles field before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
kubernetes/v2
service to support path-based routing, which allows clients to access an arbitrary number of Kubernetes clusters using a single issued identity.It can be used with
tbot start kubernetes/v2
and specifying one or more explicit clusters with--kubernetes-cluster-name
or a label selector with--kubernetes-cluster-labels
.Part of #40405. Requires #50567.
Changelog: Machine ID's new
kubernetes/v2
service supports access to multiple Kubernetes clusters by name or label without needing to issue new identities.