Migrate S3 and KMS in lib/cloud/clients to SDK v2 #51142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
aws
GavinFrazar
force-pushed
the
gavinfrazar/remove-s3-kms-from-cloud-clients
branch
3 times, most recently
from
fe61807 to
5d28872
Compare
github-actions
bot
added
database-access
greedy52
reviewed
Jan 17, 2025
GavinFrazar
force-pushed
the
gavinfrazar/remove-s3-kms-from-cloud-clients
branch
from
5d28872 to
cdd9561
Compare
greedy52
approved these changes
Jan 17, 2025
GavinFrazar
force-pushed
the
gavinfrazar/remove-s3-kms-from-cloud-clients
branch
from
cdd9561 to
fc0135f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the S3 and KMS client getters from lib/cloud/clients.
The only package that depended on the S3 client getter was in aws-sync, which was migrated to use SDK v2 clients.
The KMS client getter was not used anywhere.
Part of #14142