fix: Allow ExtKeyUsageAny for Webauthn attestation certificates #51201
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
changed the title
codingllama
commented
Jan 17, 2025
| allowed = true // OK, but keep checking | ||
| } else { | ||
| log.DebugContext(context.Background(), |
There was a problem hiding this comment.
Added some logging to help future debugging. The first certificate in the Hello chain fails validation, which is good to know (the second passes so thankfully it works).
For the curious, the error is "x509: unhandled critical extension".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Hello attestation checks fail because its attestation certificates set ExtKeyUsage 2.23.133.8.3 (and also 1.3.6.1.4.1.311.21.36, which doesn't seem to be thoroughly documented).
This PR fixes that by allowing any ExtKeyUsage to be part of attestation certificates. That is partly because there are no consts for the OIDs above, but also because it doesn't seem like a reason to fail attestation.
Changelog: Fixed WebAuthn attestation for Windows Hello