[v15] Add support for storing RDP licenses from Windows Desktops #51686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alan Parra <[email protected]> Signed-off-by: Zac Bergquist <[email protected]>
zmb3
requested review from
klizhentas,
russjones,
r0mant,
fheinecke,
camscale and
tcsc
as code owners
github-actions
bot
requested review from
codingllama,
probakowski and
rosstimothy
|
Note: this was the only backport that had conflicts - would appreciate an extra close review. |
Any files or block we should particularly pay attention to? |
codingllama
reviewed
Jan 31, 2025
|
Looks like v15 would need to bump the Rust version in order for this to build. |
rosstimothy
approved these changes
Feb 3, 2025
probakowski
force-pushed
the
zmb3/v15-backport-51250
branch
from
e7f9ea5 to
7021faf
Compare
codingllama
reviewed
Feb 11, 2025
|
It looks like this grew significantly from the original backport, would it make sense to do the dependency updates on a separate PR? Similarly, should we rebase onto the recent branch/v15 so we pull Rust upgrade and other fixes. |
Merged
probakowski
changed the base branch from
branch/v15
to
probakowski/v15-ironrdp
|
@codingllama it makes sense to split it, I've created #52081 and rebased/retargeted this PR |
codingllama
approved these changes
Feb 12, 2025
public-teleport-github-review-bot
bot
removed request for
klizhentas,
r0mant,
tcsc,
russjones,
fheinecke and
camscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #51250
Changelog: Add support for caching Microsoft Remote Desktop Services licenses