implement ssh access decision method prototype #52542
Open
+1,938
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-breakout-2
branch
6 times, most recently
from
7006482 to
07b9a43
Compare
fspmarshall
added
no-changelog
23 tasks
rosstimothy
reviewed
Feb 28, 2025
Comment on lines
+27
to
29
| decisionpb "github.com/gravitational/teleport/api/gen/proto/go/teleport/decision/v1alpha1" | ||
| headerv1 "github.com/gravitational/teleport/api/gen/proto/go/teleport/header/v1" | ||
| workloadidentityv1pb "github.com/gravitational/teleport/api/gen/proto/go/teleport/workloadidentity/v1" |
There was a problem hiding this comment.
decisionpb, headerv1, workloadidentityv1pb 🫠
There was a problem hiding this comment.
Yeah... not ideal, but until we coalesce on a standard I'm going to leave as-is. IMO more important than consistency across packages is consistency in the aliasing of any given package, to ensure that types of that package are easy to grep for.
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-breakout-2
branch
2 times, most recently
from
ce70bb6 to
2c1c6a8
Compare
rosstimothy
approved these changes
Mar 3, 2025
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-breakout-2
branch
from
2c1c6a8 to
ff401cf
Compare
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-breakout-2
branch
from
ff401cf to
dd64674
Compare
timothyb89
approved these changes
Mar 5, 2025
| c.command.Flag("username", "The username to evaluate access for.").StringVar(&c.sshDetails.username) | ||
| c.command.Flag("login", "The os login to evaluate access for.").StringVar(&c.sshDetails.login) | ||
| c.command.Flag("server-id", "The host id of the target server.").StringVar(&c.sshDetails.serverID) | ||
| c.command.Flag("username", "The username to evaluate access for.").StringVar(&c.Username) |
There was a problem hiding this comment.
would it make sense to make this required at the parser level, or is there some advantage to the empty check in Run()?
Suggested change
| c.command.Flag("username", "The username to evaluate access for.").StringVar(&c.Username) | |
| c.command.Flag("username", "The username to evaluate access for.").Required().StringVar(&c.Username) |
public-teleport-github-review-bot
bot
removed the request for review
from rudream
rudream
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements a prototype of the
EvaluateSSHAccessdecision service RPC implementation. Almost everything here is either a placeholder, or a WIP subset of the intended final logic.In addition to the core functionality of
EvaluateSSHAccess, this PR also introduces supporting functionality around generation of fake identities for dry run queries withtctl. This allows the decision service to approximate what the parameters of a users certificate identity would likely be given only their username, and use that approximation in making its decisions.The identity generation logic in this PR supersedes two previous design iterations that were proposed but never merged: #50559 and #50482. The logic here tries to strike a balance between the two previous strategies by preserving a mostly isolated set of types and codepaths for identity generation, but eliminating the need for an extra round-trip.
Part of ongoing work related to the PDP proposal (https://github.com/gravitational/teleport.e/pull/5736).