Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-600 #2571

Merged
merged 2 commits into from
Sep 18, 2023
Merged

NET-600 #2571

merged 2 commits into from
Sep 18, 2023

Conversation

uGiFarukh
Copy link
Contributor

@uGiFarukh uGiFarukh commented Sep 12, 2023

Describe your changes

  • When individual extclient dns is changed or removed, it reflects on the UI properly and also gets updated on backend.
  • Extclients DNS now properly set from ingress dns value provided that the individual extclient DNS are not present. Updated DNS only applies to newly created extclients after an ingress dns update from the netmaker UI. Individual extclients DNS which are set by user will take precedence over ingress gateway dns.

Related to NET-468 and NET-600

Provide Issue ticket number if applicable/not in title

Provide testing steps

  1. Create an ingress gateway with a DNS address set.
  2. Create extclients using this ingress gateway.
  3. Open the extclient's details page by clicking on the name.
  4. This page should reflect the DNS set on the ingress gateway.
  5. Change the ingress gateway dns server to a different one and create another extclient.
  6. New ingress gateway dns now should be reflected on the new extclient details page.
  7. Any ingress gateway dns changes should properly reflect on newly created extclients unless an extclient have dns server set through its own configuration page.
  8. Click on edit button of any extclient.
  9. Update client DNS field click on update client.
  10. Clear client DNS field and click on update client.
  11. Extclient dns should be now clearing or changing properly.

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

* Ext clients dns now properly set from ingress dns value provided that the individual ext client dns are not present.
@uGiFarukh uGiFarukh added bug Something isn't working ext client Fixed Fixed, not yet released labels Sep 12, 2023
@uGiFarukh uGiFarukh self-assigned this Sep 12, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue related to this ticket is totally different

Copy link
Contributor

@Aceix Aceix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be empty instead

* When individual extclient dns is changed or removed, it reflects on the UI properly and also gets updated on backend.
@abhishek9686 abhishek9686 merged commit 7c4870e into develop Sep 18, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ext client Fixed Fixed, not yet released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants