-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-562] Persistent Keep Alive from node to host #2604
Conversation
Will definitely need a UI change as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when a server is updated to this version; how are the host and node models updated. The new node model will just ignore the keepalive in the database, but how will the host.Keepalive value be set?
@mattkasun I've implemented logic for that in f67bff1 (f67bff1#diff-24c3832e2410ce37a7dfb88d3b4bf45a0506ce708774402fecddb5e96f9ff8d8R169) and in 10c3416, is that sufficient for your concern? |
Migrate is only called on update from v0.17.1 |
@gabrielseibel1 resolve conflicts |
Describe your changes
Move PKA from node to host level
Provide testing steps
Described in ticket