Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-698 #2671

Merged
merged 3 commits into from
Nov 27, 2023
Merged

NET-698 #2671

merged 3 commits into from
Nov 27, 2023

Conversation

uGiFarukh
Copy link
Contributor

@uGiFarukh uGiFarukh commented Nov 16, 2023 •
edited
Loading

Describe your changes

  • create emqx creds for host on pull if not found.

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@uGiFarukh
create emqx creds for host on pull if not found
87ab4e7 
* create emqx creds for host on pull if not found.
@uGiFarukh uGiFarukh added the enhancement New feature or request label Nov 16, 2023
@uGiFarukh uGiFarukh self-assigned this Nov 16, 2023
abhishek9686
abhishek9686 requested changes Nov 20, 2023
View reviewed changes
controllers/hosts.go Outdated Show resolved Hide resolved
@uGiFarukh
emqx creds creation changed to host authenticate function
f3a13ad 
* emqx creds creation changed to host authenticate function.
abhishek9686
abhishek9686 requested changes Nov 22, 2023
View reviewed changes
controllers/hosts.go Show resolved Hide resolved
@uGiFarukh
added node acls update
607e7e1 
* added node acls update.
@abhishek9686 abhishek9686 merged commit 99adc96 into develop Nov 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@theguy951357 theguy951357 Awaiting requested review from theguy951357

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@pwilson77 pwilson77 Awaiting requested review from pwilson77

@afeiszli afeiszli Awaiting requested review from afeiszli

@mattkasun mattkasun Awaiting requested review from mattkasun

Assignees

@uGiFarukh uGiFarukh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uGiFarukh @abhishek9686