Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipv6 only issue #2861

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix ipv6 only issue #2861

merged 1 commit into from
Mar 20, 2024

Conversation

yabinma
Copy link
Contributor

@yabinma yabinma commented Mar 15, 2024

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@yabinma yabinma requested a review from abhishek9686 March 15, 2024 21:29
@yabinma
Copy link
Contributor Author

yabinma commented Mar 15, 2024

@abhishek9686 , please help review. This is the fix for the issue mentioned today. If creating a ipv6 only netmaker network, it could not add host properly, and the hosts could not communicate each other properly.

After the fix, the ipv6 network can be created successfully and all the hosts added into this network work well.

image
image

@yabinma yabinma merged commit 184e33f into gravitl:NET-1088 Mar 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants