feat(FormRow): add direction prop #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
ogonkov
requested changes
Oct 2, 2023
| display: flex; | ||
| margin-bottom: 20px; | ||
|
|
||
| &_direction_row { |
There was a problem hiding this comment.
put modifiers inside element selectors pls
&__left {
#{$block}_direction_row & {}
#{$block}_direction_column & {}
}
src/components/FormRow/types.ts
Outdated
| @@ -13,6 +13,8 @@ export interface FormRowProps { | |||
| /** Field component itself. `<FormRow.FieldDescription/>` could be used here | |||
| * next to field component itself */ | |||
| children?: ReactNode; | |||
| /** Direction in which the elements are placed */ | |||
| direction?: 'row' | 'column'; | |||
There was a problem hiding this comment.
Add alias ForRowDirection for this union and export it
mournfulCoroner
force-pushed
the
feat-column-mode-FormRow
branch
from
39f8499 to
e3eaade
Compare
mournfulCoroner
force-pushed
the
feat-column-mode-FormRow
branch
from
e3eaade to
d48d3ff
Compare
ogonkov
reviewed
Oct 3, 2023
src/components/FormRow/FormRow.scss
Outdated
| } | ||
|
|
||
| #{$block}_direction_column & { | ||
| width: 100%; |
There was a problem hiding this comment.
is this required with display: flex?
ogonkov
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.