generated from gravity-ui/package-example
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: made a new password input component #108
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
810becd
feat(Password): made a new input password
NasgulNexus e7ea3aa
fix: deleted unnecessary files
NasgulNexus f69fd7f
fix: delete lodash
NasgulNexus 77b7def
fix: add stories WithGenerateRandomValueTemplate
NasgulNexus 9f89baa
fix: added browser default to ignore
NasgulNexus 110608c
fix: correct remarks
NasgulNexus 868a5ac
fix: corrected comments
NasgulNexus 7603a3d
fix: name helpers function
NasgulNexus 5c5959d
fix: fix spread control props
NasgulNexus a8098e4
Merge branch 'main' into password
NasgulNexus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import {Button} from '@gravity-ui/uikit'; | |
import type {Meta, StoryFn} from '@storybook/react'; | ||
|
||
import {cn} from '../../utils/cn'; | ||
import {PasswordInput} from '../PasswordInput'; | ||
import {PasswordInput, PasswordInputProps} from '../PasswordInput'; | ||
|
||
import './PasswordInputStories.scss'; | ||
|
||
|
@@ -13,26 +13,21 @@ const b = cn('password-input-stories'); | |
export default { | ||
title: 'Components/PasswordInput', | ||
component: PasswordInput, | ||
args: { | ||
showCopyButton: true, | ||
showRevealButton: true, | ||
}, | ||
} as Meta; | ||
|
||
const DefaultTemplate: StoryFn<React.ComponentProps<typeof PasswordInput>> = () => { | ||
const DefaultTemplate: StoryFn<PasswordInputProps> = (args) => { | ||
const [value, setValue] = React.useState(''); | ||
|
||
return ( | ||
<PasswordInput | ||
showCopyButton={true} | ||
showRevealButton={true} | ||
onUpdate={setValue} | ||
value={value} | ||
/> | ||
); | ||
return <PasswordInput {...args} onUpdate={setValue} value={value} />; | ||
}; | ||
|
||
export const Default = DefaultTemplate.bind({}); | ||
|
||
const WithGenerateRandomValueTemplate: StoryFn<React.ComponentProps<typeof PasswordInput>> = ( | ||
props: React.ComponentProps<typeof PasswordInput>, | ||
) => { | ||
const WithGenerateRandomValueTemplate: StoryFn<PasswordInputProps> = (args) => { | ||
const [value, setValue] = React.useState(''); | ||
|
||
const generateRandomValue = React.useCallback(() => { | ||
|
@@ -51,7 +46,7 @@ const WithGenerateRandomValueTemplate: StoryFn<React.ComponentProps<typeof Passw | |
|
||
return ( | ||
<div className={b()}> | ||
<PasswordInput {...props} onUpdate={setValue} value={value} /> | ||
<PasswordInput {...args} onUpdate={setValue} value={value} /> | ||
<Button onClick={generateRandomValue} className={b('button-generate-random-value')}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add prop |
||
Generate random value | ||
</Button> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import type {ButtonSize, InputControlSize} from '@gravity-ui/uikit'; | ||
|
||
export const getCopyButtonSizeAndIconSize = ( | ||
textInputSize: InputControlSize, | ||
): {copyButtonSize: ButtonSize; iconSize: number} => { | ||
let copyButtonSize: ButtonSize = 's'; | ||
let iconSize = 16; | ||
|
||
switch (textInputSize) { | ||
case 's': { | ||
copyButtonSize = 'xs'; | ||
iconSize = 12; | ||
break; | ||
} | ||
case 'l': { | ||
copyButtonSize = 'm'; | ||
break; | ||
} | ||
case 'xl': { | ||
copyButtonSize = 'l'; | ||
iconSize = 20; | ||
} | ||
} | ||
|
||
return {copyButtonSize, iconSize}; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spread should be before the className, otherwise it would be overwritten by the controlProps