-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update uikit, improve a11y for sharepopover #111
Conversation
Preview is ready. |
@@ -11,11 +12,14 @@ $block: '.#{variables.$ns}share-popover'; | |||
} | |||
|
|||
&__container { | |||
@include mixins.button-reset(); | |||
@include mixins.focusable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Because
container
element isbutton
tag now. Need to reset button styles therefore. - Fixed by disabling portal
src/components/utils/getUniqId.ts
Outdated
import {NAMESPACE} from './cn'; | ||
|
||
let id = 1; | ||
export function getUniqId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rework this function and use it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/gravity-ui/uikit/pull/1070 – the same function will be exported here from uikit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPD: decided to use tooltipId
from props
3c60f50
to
177862b
Compare
b7efa32
to
278e120
Compare
278e120
to
fc690ad
Compare
No description provided.