Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OnboardingMenu component #121

Merged
merged 8 commits into from
Mar 19, 2024
Merged

feat: add OnboardingMenu component #121

merged 8 commits into from
Mar 19, 2024

Conversation

nikita-jpg
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@nikita-jpg nikita-jpg marked this pull request as ready for review November 30, 2023 18:04
@nikita-jpg nikita-jpg changed the title Guide UXRFC-255: Guide Nov 30, 2023
@nikita-jpg nikita-jpg force-pushed the Guide branch 3 times, most recently from f118c05 to 3ac6c1c Compare February 21, 2024 12:03
amje
amje requested changes Feb 27, 2024
View reviewed changes
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/GuideMenuItem/GuideMenuItem.scss Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.scss Outdated Show resolved Hide resolved
src/components/OnboardingGuide/Guide/Guide.tsx Outdated Show resolved Hide resolved
@nikita-jpg nikita-jpg requested a review from amje March 5, 2024 11:33
amje
amje requested changes Mar 11, 2024
View reviewed changes
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/components/OnboardingMenuItem/OnboardingMenuItem.tsx Outdated Show resolved Hide resolved
...nents/OnboardingMenuItem/frequentFunctions/OnboardingMenuItemText/OnboardingMenuItemText.tsx Outdated Show resolved Hide resolved
...nents/OnboardingMenuItem/frequentFunctions/OnboardingMenuItemText/OnboardingMenutemText.scss Outdated Show resolved Hide resolved
...nts/OnboardingMenuItem/frequentFunctions/OnboardingMenutemImage/OnboardingMenuItemImage.scss Outdated Show resolved Hide resolved
...ents/OnboardingMenuItem/frequentFunctions/OnboardingMenutemImage/OnboardingMenuItemImage.tsx Outdated Show resolved Hide resolved
@nikita-jpg nikita-jpg requested a review from amje March 15, 2024 11:28
amje
amje requested changes Mar 18, 2024
View reviewed changes
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.scss Outdated Show resolved Hide resolved
src/components/OnboardingMenu/components/OnboardingMenuItem/OnboardingMenuItem.tsx Outdated Show resolved Hide resolved
src/components/OnboardingMenu/components/OnboardingMenuItem/OnboardingMenuItem.tsx Outdated Show resolved Hide resolved
src/components/OnboardingMenu/components/OnboardingMenuItem/OnboardingMenuItem.scss Outdated Show resolved Hide resolved
...nents/OnboardingMenuItem/frequentFunctions/OnboardingMenuItemText/OnboardingMenuItemText.tsx Outdated Show resolved Hide resolved
src/components/OnboardingMenu/OnboardingMenu.tsx Outdated Show resolved Hide resolved
@nikita-jpg nikita-jpg requested a review from amje March 19, 2024 08:51
@amje amje changed the title UXRFC-255: Guide feat: add OnboardingMenu component Mar 19, 2024
amje
amje reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@amje amje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use this naming:

OnboardingMenu.Item
OnboardingMenu.ItemText
OnboardingMenu.ItemImage

@gravity-ui gravity-ui deleted a comment from nikita-jpg Mar 19, 2024
@nikita-jpg nikita-jpg requested a review from amje March 19, 2024 14:26
@nikita-jpg nikita-jpg requested a review from amje March 19, 2024 14:43
@nikita-jpg nikita-jpg merged commit e296ed4 into main Mar 19, 2024
3 checks passed
@nikita-jpg nikita-jpg deleted the Guide branch March 19, 2024 15:01
@gravity-ui-bot gravity-ui-bot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje amje approved these changes

@ValeraS ValeraS Awaiting requested review from ValeraS

@korvin89 korvin89 Awaiting requested review from korvin89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-jpg @gravity-ui-bot @amje