feat(Stories): add hook for sync tabs #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyoue
changed the title
|
Preview is ready. |
DarkGenius
reviewed
Feb 2, 2024
src/components/Stories/Stories.tsx
Outdated
| @@ -48,13 +51,21 @@ export function Stories({ | |||
| [onClose], | |||
| ); | |||
|
|
|||
| const {callback: closeWithLS} = useSyncWithLS<NonNullable<StoriesProps['onClose']>>({ | |||
| callback: (event, reason) => { | |||
| if (syncInTabs) onClose?.(event, reason); | |||
There was a problem hiding this comment.
Is it necessary to check syncInTabs here?
DarkGenius
reviewed
Feb 2, 2024
| @@ -62,6 +62,7 @@ const DefaultTemplate: StoryFn<StoriesProps> = (props: StoriesProps) => { | |||
| <Stories | |||
| {...props} | |||
| open={visible} | |||
| syncInTabs={props.syncInTabs} | |||
There was a problem hiding this comment.
Above, with the restructuring of props, syncInTabs also will be set, right?
DarkGenius
approved these changes
Feb 2, 2024
burashka
approved these changes
Feb 5, 2024
vanilla-wave
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UXRFC-300.
Perform action in multiple tabs simultaneously using Local Storage key and 'storage' event listener.