Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update storybook up to v8 #180

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: update storybook up to v8 #180

merged 3 commits into from
Apr 10, 2024

Conversation

NikitaCG
Copy link
Contributor

@NikitaCG NikitaCG commented Apr 8, 2024

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Copy link
Contributor

@ValeraS ValeraS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use npx storybook@latest upgrade?

@@ -12,6 +12,7 @@ const config: StorybookConfig = {
'@storybook/preset-scss',
{name: '@storybook/addon-essentials', options: {backgrounds: false}},
'./theme-addon/register.tsx',
'@storybook/addon-webpack5-compiler-babel',
],

webpackFinal: (storybookBaseConfig) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need these config changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastRefresh option is removed.

package.json Outdated
"@storybook/theming": "^7.6.12",
"@storybook/react": "8.0.5",
"@storybook/react-webpack5": "8.0.5",
"@storybook/theming": "8.0.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storybook package is absent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start and build-storybook scripts should be updated.

@NikitaCG NikitaCG force-pushed the chore/update-storybook8 branch from 2c51c36 to 1c6449c Compare April 8, 2024 17:21
@NikitaCG
Copy link
Contributor Author

NikitaCG commented Apr 8, 2024

Did you use npx storybook@latest upgrade?

updated up to 8.0.6

@NikitaCG NikitaCG force-pushed the chore/update-storybook8 branch from 1c6449c to db8e57e Compare April 9, 2024 11:00
@NikitaCG NikitaCG merged commit 4c1bbab into main Apr 10, 2024
3 checks passed
@NikitaCG NikitaCG deleted the chore/update-storybook8 branch April 10, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants