feat(Reactions): add addButtonPlacement property
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
amje
requested changes
Sep 2, 2024
| * | ||
| * @default 'right' | ||
| */ | ||
| addButtonPosition?: 'left' | 'right' | 'none'; |
There was a problem hiding this comment.
Let's separate hiding and placement, also we use logical values (start/end) instead of physical ones (left/right)
Suggested change
| addButtonPosition?: 'left' | 'right' | 'none'; | |
| addButtonPlacement?: 'start' | 'end'; |
none value is the same as readOnly, isn't it?
There was a problem hiding this comment.
- Turned
left/righttostart/end - Moved
noneto a separate propertyhideAddButton
nonevalue is the same asreadOnly, isn't it?
Not quite. You can still toggle reactions, it's just the button that hides
|
@amje ping |
amje
changed the title
addButtonPlacement property
amje
approved these changes
Sep 5, 2024
Ruminat
deleted the
feat-added-addButtonPosition-prop-to-Reactions-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a property (addButtonPosition) for placing the "Add reaction" button:
The default (
right) stays the same