Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stories): Add content property #225

Merged
merged 4 commits into from
Oct 12, 2024
Merged

feat(Stories): Add content property #225

merged 4 commits into from
Oct 12, 2024

Conversation

mytwink
Copy link
Contributor

@mytwink mytwink commented Oct 9, 2024

ReactNode is more flexible, suggest new content property and mark description as deprecated.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@mytwink mytwink marked this pull request as ready for review October 9, 2024 15:42
@mytwink mytwink requested a review from DarkGenius as a code owner October 9, 2024 15:42
@mytwink mytwink requested review from amje and removed request for DarkGenius October 9, 2024 15:42
@@ -60,6 +60,11 @@ export const StoriesLayout = (props: StoriesLayoutProps) => {
{currentStory.description}
</div>
)}
{currentStory.content && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to display only content, and if it is not defined, fallback to description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mytwink mytwink merged commit 3b59e08 into main Oct 12, 2024
4 checks passed
@mytwink mytwink deleted the stories-content branch October 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants