Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed clearing actionParams on empty changed params #103

Closed
wants to merge 1 commit into from
Closed

fix: changed clearing actionParams on empty changed params #103

wants to merge 1 commit into from

Conversation

Marginy605
Copy link
Collaborator

No description provided.

@Marginy605 Marginy605 requested a review from jhoncool as a code owner December 1, 2023 12:51
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@jhoncool
Copy link
Collaborator

jhoncool commented Dec 7, 2023 •
edited
Loading

@Marginy605 what if we will add an optional arg to plugin method onStateAndParamsChange like:
onStateAndParamsChange: (stateAndParams: ItemStateAndParams, options?: {command: 'remove'}) => void;

Because we need to remove widget id from the state queue. I think this is a clearer way.
And it may be useful in the future when we will update action params partially

@jhoncool
Copy link
Collaborator

I will close this PR because it's implemented here #105

@jhoncool jhoncool closed this Dec 12, 2023
@Marginy605 Marginy605 deleted the ap-clear-change branch April 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoncool jhoncool Awaiting requested review from jhoncool jhoncool is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marginy605 @gravity-ui-bot @jhoncool