feat(react-query): update to major v5 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DakEnviy
force-pushed
the
feat/update-react-query-5
branch
7 times, most recently
from
b6a50e2 to
99a732d
Compare
DakEnviy
force-pushed
the
feat/update-react-query-5
branch
2 times, most recently
from
29790c5 to
f752904
Compare
personaljs
approved these changes
Aug 12, 2024
| @@ -1,5 +1,5 @@ | |||
| // TODO(DakEnviy): Do not use react-query in core | |||
There was a problem hiding this comment.
Yeah, just a reminder to find another function for hashing in the future
| @@ -11,10 +14,10 @@ export const useInfiniteQueryData = <TDataSource extends AnyInfiniteQueryDataSou | |||
| context: DataSourceContext<TDataSource>, | |||
| dataSource: TDataSource, | |||
| params: DataSourceParams<TDataSource>, | |||
| options?: DataSourceOptions<TDataSource>, | |||
| ) => { | |||
| options?: Partial<DataSourceOptions<TDataSource>>, | |||
There was a problem hiding this comment.
Can you move partial type to DataSourceOptions?
There was a problem hiding this comment.
I believe that having origin options can be useful
| if (status === 'loading' && fetchStatus === 'idle') { | ||
| if (status === 'pending') { | ||
| if (fetchStatus === 'fetching') { | ||
| return 'loading'; |
There was a problem hiding this comment.
loading should tell to draw a loader, it's like isLoading boolean flag is useQuery result. pending has a little bit different meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.