feat(EditorView): add selectable nodes

gravity-ui · Dec 20, 2024 · d25bc11 · d25bc11
1 parent 89c9881
commit d25bc11
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/src/extensions/additional/Math/MathSpecs/index.ts b/src/extensions/additional/Math/MathSpecs/index.ts
@@ -45,6 +45,7 @@ export const MathSpecs: ExtensionAuto = (builder) => {
                 code: true,
                 toDOM: () => ['div', {class: 'math-block'}, 0],
                 parseDOM: [{tag: 'div.math-block', priority: 200}],
+                selectable: true,
             },
             fromMd: {
                 tokenName: 'math_block',

diff --git a/src/extensions/base/BaseSchema/BaseSchemaSpecs/index.ts b/src/extensions/base/BaseSchema/BaseSchemaSpecs/index.ts
@@ -54,6 +54,7 @@ export const BaseSchemaSpecs: ExtensionAuto<BaseSchemaSpecsOptions> = (builder,
                         0,
                     ];
                 },
+                selectable: true,
                 placeholder: opts.paragraphPlaceholder
                     ? {
                           content: opts.paragraphPlaceholder,

diff --git a/src/extensions/behavior/Selection/selection.ts b/src/extensions/behavior/Selection/selection.ts
@@ -99,18 +99,16 @@ const getTopLevelNodesFromSelection = (selection: Selection, doc: Node) => {
     const nodes: {node: Node; pos: number}[] = [];
     if (selection.from !== selection.to) {
         const {from, to} = selection;
+
         doc.nodesBetween(from, to, (node, pos) => {
             const withinSelection = from <= pos && pos + node.nodeSize <= to;
-            if (
-                node &&
-                node.type.name !== 'paragraph' &&
-                !node.isText &&
-                node.type.spec.selectable &&
-                withinSelection
-            ) {
+
+            if (node && !node.isText && node.type.spec.selectable && withinSelection) {
                 nodes.push({node, pos});
+
                 return false;
             }
+
             return true;
         });
     }

diff --git a/src/extensions/markdown/Blockquote/BlockquoteSpecs/index.ts b/src/extensions/markdown/Blockquote/BlockquoteSpecs/index.ts
@@ -17,6 +17,7 @@ export const BlockquoteSpecs: ExtensionAuto = (builder) => {
             toDOM() {
                 return ['blockquote', 0];
             },
+            selectable: true,
         },
         fromMd: {tokenSpec: {name: blockquoteNodeName, type: 'block'}},
         toMd: (state, node) => {

diff --git a/src/extensions/markdown/HorizontalRule/HorizontalRuleSpecs/index.ts b/src/extensions/markdown/HorizontalRule/HorizontalRuleSpecs/index.ts
@@ -14,6 +14,7 @@ export const HorizontalRuleSpecs: ExtensionAuto = (builder) => {
             toDOM() {
                 return ['div', ['hr']];
             },
+            selectable: true,
         },
         fromMd: {
             tokenName: 'hr',

diff --git a/src/extensions/yfm/YfmTabs/YfmTabsSpecs/schema.ts b/src/extensions/yfm/YfmTabs/YfmTabsSpecs/schema.ts
@@ -78,6 +78,7 @@ export const getSchemaSpecs: (
         toDOM(node) {
             return ['div', node.attrs, 0];
         },
+        selectable: true,
         complex: 'root',
     },
-Original file line number
+Diff line change
@@ Expand Up @@
 ,
                         ];
                     },
+                    selectable: true,
                     placeholder: opts.paragraphPlaceholder
                         ? {
                               content: opts.paragraphPlaceholder,
@@ Expand Down @@