Feat/mobile mvp #588
Draft
Feat/mobile mvp #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
I changed target branch to I suggest reviewing and merging this PR after we migrating to uikit7 |
iapolya
force-pushed
the
feat/mobile-mvp
branch
2 times, most recently
from
05c6811 to
b98ca42
Compare
iapolya
force-pushed
the
feat/mobile-mvp
branch
2 times, most recently
from
4bce3f6 to
7c5aaca
Compare
iapolya
force-pushed
the
feat/mobile-mvp
branch
from
7c5aaca to
7d44037
Compare
iapolya
force-pushed
the
feat/mobile-mvp
branch
from
236d26f to
bedb3ff
Compare
makhnatkin
reviewed
Feb 18, 2025
| const wCommandMenuConfig = cloneDeep(wysiwygToolbarConfigs.wCommandMenuConfig); | ||
| wCommandMenuConfig.unshift(wGptItemData); | ||
|
|
||
| const mToolbarConfig = cloneDeep(markupToolbarConfigs.mToolbarConfig); |
There was a problem hiding this comment.
lets use toolbarPresets
| export const mobilePreset: ToolbarsPreset = { | ||
| items: { | ||
| ...zero.items, | ||
| [Action.bold]: { |
There was a problem hiding this comment.
why do you need a new preset? Should the toolbar be any different?
|
|
||
| const b = cn('select-popup'); | ||
|
|
||
| export const SelectPopup: FC<SelectPopupProps> = ({ |
There was a problem hiding this comment.
It doesn't seem like the best name, I would suggest PlatformPopup
|
|
||
| import {SelectPopup} from '../bundle/SelectPopup'; |
There was a problem hiding this comment.
the dependence should be the other way around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Popup list (sheet?): Action.emoji, Action.colorify
Complex popup (100% design is required) 1: Action.file, Action.image, Action.imagePopup, Action.link,
Complex actions: Action.table, Action.filePopup
Under consideration: Action.horizontalRule