test(BackgroundMedia): test for BackgroundMedia added #170
Conversation
niktverd
force-pushed
the
test/background_media
branch
from
84ec579 to
0286995
Compare
|
Preview is ready. |
niktverd
force-pushed
the
test/background_media
branch
from
e0860aa to
aff2faf
Compare
src/components/Media/Image/Image.tsx
Outdated
| @@ -78,7 +80,7 @@ const Image = (props: ImageAllProps) => { | |||
| const imageBackground = (oneImage: ImageProps) => { | |||
| const imageData = getMediaImage(oneImage); | |||
| return ( | |||
| <animated.div style={{transform: parallaxInterpolate}}> | |||
| <animated.div style={{transform: parallaxInterpolate}} data-qa={qaIdOfAnimatedDiv}> | |||
There was a problem hiding this comment.
Don't we need custom qa here too?
There was a problem hiding this comment.
Now, it seems to me that we do not need custom ones
I cannot see necessity to pass a bunch of qaIds so deep in a component.
What we can do here is add a custom role to <animated.div />
<animated.div role="animated-div" />By this way in a test we can access this element like
screen.getByRole('animated-div') // instead of screen.getByTestId(qaIdOfAnimatedDiv)There was a problem hiding this comment.
UPDATE: Have talk to Andrey. Adding role is not good idea. Describe it test's readme
niktverd
force-pushed
the
test/background_media
branch
from
aff2faf to
6654cfb
Compare
| expect(component).toHaveStyle(style); | ||
| }); | ||
|
|
||
| test('render video with defined height', () => { |
There was a problem hiding this comment.
maybe custom instead of defined?
Here and in other places
src/components/Media/Video/Video.tsx
Outdated
| <div | ||
| className={b('wrap', videoClassName)} | ||
| style={{height}} | ||
| data-qa={defaultMediaVideoQa} |
There was a problem hiding this comment.
I saw in other places qa || defaultMediaVideoQa
Should we add here custom qa too?
There was a problem hiding this comment.
Slightly changed common way we assert qa attributes. Thank you for point on this pattern
niktverd
force-pushed
the
test/background_media
branch
from
872ca66 to
491d1f1
Compare
niktverd
force-pushed
the
test/background_media
branch
from
5081b1f to
e22eeee
Compare
No description provided.