Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add analyticsEvents to BackgroundCard & add link animation for cards without shadow #559

Merged
merged 2 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/models/constructor-items/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,10 @@ export interface PriceDetailsProps {
items?: PriceDetailsSettingsProps[] | PriceDetailsListProps[];
}

export interface PriceItemProps extends PriceDetailsProps, PriceDescriptionProps {}
export interface PriceItemProps
extends PriceDetailsProps,
PriceDescriptionProps,
AnalyticsEventsBase {}

export interface PriceFoldableDetailsProps {
title: string;
Expand Down
6 changes: 4 additions & 2 deletions src/models/constructor-items/sub-blocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export interface QuoteProps extends Themable, CardBaseProps {

export interface BackgroundCardProps
extends CardBaseProps,
AnalyticsEventsBase,
Omit<ContentBlockProps, 'colSizes' | 'centered'> {
url?: string;
background?: ThemeSupporting<ImageObjectProps>;
Expand All @@ -109,6 +110,7 @@ export interface BackgroundCardProps

export interface BasicCardProps
extends CardBaseProps,
AnalyticsEventsBase,
Omit<ContentBlockProps, 'colSizes' | 'centered' | 'size' | 'theme'> {
url: string;
icon?: ImageProps;
Expand All @@ -126,9 +128,9 @@ export interface BannerCardProps {
button: Pick<ButtonProps, 'text' | 'url' | 'target'>;
}

export interface MediaCardProps extends MediaProps, CardBaseProps {}
export interface MediaCardProps extends MediaProps, AnalyticsEventsBase, CardBaseProps {}

export interface LayoutItemProps extends ClassNameProps {
export interface LayoutItemProps extends ClassNameProps, AnalyticsEventsBase {
content: Omit<ContentBlockProps, 'colSizes' | 'centered' | 'size'>;
media: MediaProps;
metaInfo?: string[];
Expand Down
5 changes: 3 additions & 2 deletions src/sub-blocks/BackgroundCard/BackgroundCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,19 @@ const BackgroundCard = (props: BackgroundCardProps) => {
theme: cardTheme = 'default',
links,
buttons,
analyticsEvents,
} = props;

const {themeValue: theme} = useContext(ThemeValueContext);
const hasBackgroundColor = backgroundColor || cardTheme !== 'default';
const link = hasBackgroundColor || border === 'line' ? undefined : url;
const borderType = hasBackgroundColor ? 'none' : border;

return (
<CardBase
className={b({padding: paddingBottom, theme: cardTheme})}
url={link}
url={url}
border={borderType}
analyticsEvents={analyticsEvents}
>
<CardBase.Content>
<BackgroundImage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,23 @@ const BackgroundColorTemplate: StoryFn<BackgroundCardProps> = (args) => (
</div>
);

const WithUrlTemplate: StoryFn<{items: BackgroundCardProps[]}> = (args) => (
<div style={{display: 'flex'}}>
{args.items.map((item, i) => (
<div style={{maxWidth: '400px', padding: '0 8px'}} key={i}>
<BackgroundCard {...item} />
</div>
))}
</div>
);

export const Default = DefaultTemplate.bind({});
export const WithBackgroundImage = DefaultTemplate.bind({});
export const Paddings = PaddingsTemplate.bind({});
export const CardThemes = CardThemesTemplate.bind([]);
export const BorderLine = DefaultTemplate.bind({});
export const BackgroundColor = BackgroundColorTemplate.bind({});
export const WithUrl = WithUrlTemplate.bind({});

const DefaultArgs = {
title: data.common.title,
Expand Down Expand Up @@ -128,3 +139,17 @@ BackgroundColor.args = {
...DefaultArgs,
...data.backgroundColor.content,
} as BackgroundCardProps;

WithUrl.args = {
items: [
data.cardThemes.content[1],
data.withBackgroundImage.content,
data.borderLine.content,
data.backgroundColor.content,
data.borderNone.content,
].map((item) => ({
...DefaultArgs,
...item,
url: data.url,
})) as BackgroundCardProps[],
};
6 changes: 6 additions & 0 deletions src/sub-blocks/BackgroundCard/__stories__/data.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@
"border": "line"
}
},
"borderNone": {
"content": {
"border": "none"
}
},
"url": "https://example.com",
"paddings": {
"title": "Padding Bottom = {{padding}}"
},
Expand Down
14 changes: 14 additions & 0 deletions src/sub-blocks/BackgroundCard/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import _ from 'lodash';

import {ImageObjectProps} from '../../components/Image/schema';
import {BaseProps, CardBase, withTheme} from '../../schema/validators/common';
import {AnalyticsEventSchema} from '../../schema/validators/event';
import {ContentBase} from '../Content/schema';

const BackgroundCardContentProps = _.omit(ContentBase, ['size']);
Expand All @@ -25,6 +26,19 @@ export const BackgroundCard = {
type: 'string',
enum: ['s', 'm', 'l', 'xl'],
},
analyticsEvents: {
oneOf: [
{
...AnalyticsEventSchema,
optionName: 'single',
},
{
type: 'array',
items: AnalyticsEventSchema,
optionName: 'list',
},
],
},
},
},
};
19 changes: 19 additions & 0 deletions src/sub-blocks/BasicCard/__stories__/BasicCard.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,24 @@ const WithBorderTemplate: StoryFn<BasicCardProps> = (args) => (
</div>
);

const WithUrlTemplate: StoryFn<BasicCardProps> = (args) => (
<div style={{display: 'flex', padding: '40px 0'}}>
<div style={{maxWidth: '400px', padding: '0 8px'}}>
<BasicCard {...args} title={getCardWithBorderTitle('shadow')} />
</div>
<div style={{maxWidth: '400px', padding: '0 8px'}}>
<BasicCard {...args} border="line" title={getCardWithBorderTitle('line')} />
</div>
<div style={{maxWidth: '400px', padding: '0 8px'}}>
<BasicCard {...args} border="none" title={getCardWithBorderTitle('none')} />
</div>
</div>
);

export const Default = DefaultTemplate.bind({});
export const WithIcon = WithIconTemplate.bind({});
export const WithBorder = WithBorderTemplate.bind({});
export const WithUrl = WithUrlTemplate.bind({});

const DefaultArgs = {
...data.default.content,
Expand All @@ -75,3 +90,7 @@ Default.args = {
} as BasicCardProps;
WithIcon.args = DefaultArgs as BasicCardProps;
WithBorder.args = DefaultArgs as BasicCardProps;
WithUrl.args = {
url: data.url,
...DefaultArgs,
} as BasicCardProps;
2 changes: 1 addition & 1 deletion src/sub-blocks/BasicCard/__stories__/data.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
"withBorder": {
"title": "Card with border {{border}}"
},
"url": "https://example.com",
"default": {
"content": {
"url": "https://example.com",
"title": "Lorem ipsum",
"text": "**Ut enim ad minim veniam** [quis nostrud](https://example.com) exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat."
}
Expand Down
4 changes: 3 additions & 1 deletion src/sub-blocks/LayoutItem/LayoutItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const LayoutItem = ({
border,
fullscreen,
className,
analyticsEvents,
}: LayoutItemProps) => (
<div className={b(null, className)}>
{fullscreen && hasFullscreen(media) ? (
Expand All @@ -31,11 +32,12 @@ const LayoutItem = ({
{...media}
{...fullscreenMediaProps}
className={b('media', {border}, mediaClassName)}
analyticsEvents={analyticsEvents}
/>
)}
</FullscreenMedia>
) : (
<Media {...media} className={b('media', {border})} />
<Media {...media} className={b('media', {border})} analyticsEvents={analyticsEvents} />
)}
{metaInfo && <MetaInfo items={metaInfo} className={b('meta-info')} />}
<div className={b('content')}>
Expand Down
14 changes: 14 additions & 0 deletions src/sub-blocks/LayoutItem/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {omit} from 'lodash';

import metaInfo from '../../components/MetaInfo/schema';
import {BaseProps, MediaProps} from '../../schema/validators/common';
import {AnalyticsEventSchema} from '../../schema/validators/event';
import {ContentBase} from '../../sub-blocks/Content/schema';

export const LayoutItem = {
Expand All @@ -19,5 +20,18 @@ export const LayoutItem = {
fullscreen: {
type: 'boolean',
},
analyticsEvents: {
oneOf: [
{
...AnalyticsEventSchema,
optionName: 'single',
},
{
type: 'array',
items: AnalyticsEventSchema,
optionName: 'list',
},
],
},
},
};
9 changes: 7 additions & 2 deletions src/sub-blocks/MediaCard/MediaCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@ import './MediaCard.scss';

const b = block('MediaCard');

const MediaCard = ({border, ...mediaProps}: MediaCardProps) => (
<CardBase className={b()} bodyClassName={b('body')} border={border}>
const MediaCard = ({border, analyticsEvents, ...mediaProps}: MediaCardProps) => (
<CardBase
className={b()}
bodyClassName={b('body')}
border={border}
analyticsEvents={analyticsEvents}
>
<CardBase.Content>
<Media {...mediaProps} />
</CardBase.Content>
Expand Down
14 changes: 14 additions & 0 deletions src/sub-blocks/MediaCard/schema.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {AnimatableProps, BaseProps, CardBase, MediaProps} from '../../schema/validators/common';
import {AnalyticsEventSchema} from '../../schema/validators/event';

export const MediaCardBlock = {
'media-card': {
Expand All @@ -9,6 +10,19 @@ export const MediaCardBlock = {
...CardBase,
...MediaProps,
...AnimatableProps,
analyticsEvents: {
oneOf: [
{
...AnalyticsEventSchema,
optionName: 'single',
},
{
type: 'array',
items: AnalyticsEventSchema,
optionName: 'list',
},
],
},
},
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {CardBase} from '../../../components';
import {BREAKPOINTS} from '../../../constants';
import {Col, Grid, GridColumnSize, Row} from '../../../grid';
import {
AnalyticsEventsBase,
CardBorder,
PriceDescriptionProps,
PriceDetailsListProps,
Expand All @@ -24,7 +25,7 @@ const CombinedPricesGroupSize = {
[GridColumnSize.Lg]: 3,
};

interface CombinedPriceDetailedProps {
interface CombinedPriceDetailedProps extends AnalyticsEventsBase {
items: PriceItemProps[];
numberGroupItems: number;
useMixedView?: boolean;
Expand All @@ -43,6 +44,7 @@ const CombinedPriceDetailed = (props: CombinedPriceDetailedProps) => {
useMixedView,
getDescriptionComponent,
getDetailsComponent,
analyticsEvents,
} = props;

const [groupItemsSize, setGroupItemsSize] = useState<number>(numberGroupItems);
Expand Down Expand Up @@ -103,7 +105,7 @@ const CombinedPriceDetailed = (props: CombinedPriceDetailedProps) => {
const chunkedItems = _.chunk(items, groupItemsSize);

return (
<CardBase className={b()} border={border}>
<CardBase className={b()} border={border} analyticsEvents={analyticsEvents}>
<CardBase.Content>
<Grid>
{chunkedItems.map((chunk: PriceItemProps[], id) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@ const SeparatePriceDetailed = (props: SeparatePriceDetailedProps) => {

return (
<Fragment>
{items.map((item: PriceItemProps, id: number) => (
<CardBase key={id} className={b()} border={border}>
{items.map(({analyticsEvents, ...item}: PriceItemProps, id: number) => (
<CardBase
key={id}
className={b()}
border={border}
analyticsEvents={analyticsEvents}
>
<CardBase.Content>
{getDescriptionComponent(item)}
{getDetailsComponent(item.items)}
Expand Down
14 changes: 14 additions & 0 deletions src/sub-blocks/PriceDetailed/schema.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {AnimatableProps, BaseProps, textSize} from '../../schema/validators/common';
import {AnalyticsEventSchema} from '../../schema/validators/event';
import {filteredArray} from '../../schema/validators/utils';

const PriceDetailedDetailsType = ['marked-list', 'settings'];
Expand Down Expand Up @@ -162,6 +163,19 @@ const PriceItem = {
properties: {
...PriceDetailsProps,
...PriceDescriptionProps,
analyticsEvents: {
oneOf: [
{
...AnalyticsEventSchema,
optionName: 'single',
},
{
type: 'array',
items: AnalyticsEventSchema,
optionName: 'list',
},
],
},
},
};

Expand Down
4 changes: 3 additions & 1 deletion styles/mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@

&_border_line,
&_border_none {
cursor: default;
@if $hover {
@include card-hover();
}
}

&_border_shadow {
Expand Down