feat: add border to media in media-block #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
gorgeousvlad
previously approved these changes
Nov 29, 2023
yuberdysheva
suggested changes
Nov 29, 2023
src/blocks/Media/Media.tsx
Outdated
| @@ -16,7 +16,7 @@ export const MediaBlock = (props: MediaBlockProps) => { | |||
| return ( | |||
| <MediaBase {...props} onScroll={() => setPlay(true)}> | |||
| <MediaBase.Card> | |||
| <Media {...mediaThemed} playVideo={play} /> | |||
| <Media {...mediaThemed} playVideo={play} border={border} rounded /> | |||
There was a problem hiding this comment.
PR was completely refactored. In discussion we came up with the solution that there should be an mixin added to media component
| @@ -29,4 +29,6 @@ import * as MediaStories from './Media.stories.tsx'; | |||
|
|
|||
| [`buttons?: Button[]` — An array with button objects](?path=/docs/documentation-types--docs#button) | |||
|
|
|||
| `border?: boolean` — Image border | |||
There was a problem hiding this comment.
Can we use here types border: 'line' | 'shadow' | 'none'
we can set 'shadow' as !disableShadow and deprecate this prop
yuberdysheva
suggested changes
Nov 29, 2023
src/components/Media/Media.scss
Outdated
| border: 1px solid var(--g-color-line-generic); | ||
| } | ||
|
|
||
| &_rounded { |
There was a problem hiding this comment.
It was rounded before if I am not mistaken?
There was a problem hiding this comment.
PR was completely refactored. In discussion we came up with the solution that there should be an mixin added to media component
This decision made this comment non-relevant
niktverd
force-pushed
the
add_border_to_media_in_media_block
branch
from
6dfb5f6 to
13f5128
Compare
niktverd
changed the title
niktverd
force-pushed
the
add_border_to_media_in_media_block
branch
from
13f5128 to
dc93876
Compare
gorgeousvlad
requested changes
Dec 6, 2023
src/blocks/Media/Media.tsx
Outdated
| const {media} = props; | ||
| const {media, border = 'shadow', disableShadow} = props; | ||
|
|
||
| const mediaBaseShadow = disableShadow || border !== 'shadow'; |
There was a problem hiding this comment.
We need another naming for mediaBaseShadow because it is boolean flag
gorgeousvlad
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.