feat: add background for card-layout-block #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
gorgeousvlad
suggested changes
Dec 29, 2023
| position: relative; | ||
|
|
||
| &_with-background { | ||
| padding: 8px 32px 48px; |
There was a problem hiding this comment.
this indents should be from variables
src/blocks/CardLayout/CardLayout.tsx
Outdated
| ); | ||
| background, | ||
| }) => { | ||
| const withBackground = Boolean( |
There was a problem hiding this comment.
why not just const withBackground = Boolean(background) ?
There was a problem hiding this comment.
Theoretically it is possible to pass an empty object to background prop which would do nothing inside the BackgroundImage rendering but it adds additional indents.
I added the same logic in the src/blocks/Form/Form.tsx as well.
Should I fix it also?
qradle-yndx
force-pushed
the
feat/add-card-layout-background
branch
from
b2878e4 to
77d7b5d
Compare
gorgeousvlad
previously approved these changes
Jan 9, 2024
gorgeousvlad
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.