feat: add image card sub-block #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qradle-yndx
force-pushed
the
feat/image-card
branch
from
605c7db to
8e8de23
Compare
|
Preview is ready. |
NikitaCG
requested changes
Feb 13, 2024
| #{$image}_inner#{$image}_inner_radius { | ||
| border-radius: $borderRadius; | ||
| } | ||
| } |
| className={b({border, 'with-content': hasContent, direction})} | ||
| style={{backgroundColor}} | ||
| > | ||
| {direction === ImageCardDirection.Direct && ( |
There was a problem hiding this comment.
I think we need to change the direction with style, not with code.
flex-direction rule in container
| </div> | ||
| ); | ||
| }; | ||
| const renderImage = () => { |
There was a problem hiding this comment.
and when we change directions with style we dont need this functions, we'll render this code immediately in return()
| @@ -57,6 +58,17 @@ export interface IconWrapperProps { | |||
| icon?: PositionedIcon; | |||
| } | |||
|
|
|||
| export enum ImageCardMargins { | |||
| None = 'none', | |||
There was a problem hiding this comment.
do we really need the none parameter? We can just have a default state (now is none) and change it somehow when there is a demand for s or m
NikitaCG
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.