fix: test ci if

gravity-ui · Nov 16, 2023 · 7add330 · 7add330
1 parent a0a8580
commit 7add330
Show file tree

Hide file tree

Showing 29 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -23,14 +23,12 @@ jobs:
       env:
         CI: 'true'
     - name: Upload Playwright playwright report to GitHub Actions Artifacts
-      if: always()
       uses: actions/upload-artifact@v3
       with:
         name: playwright-report
         path: playwright-report
         retention-days: 1
     - name: Upload Playwright report
-      if: always()
       env:
         AWS_ACCESS_KEY_ID: ${{ secrets.STORYBOOK_S3_KEY_ID }}
         AWS_SECRET_ACCESS_KEY: ${{ secrets.STORYBOOK_S3_SECRET_KEY }}
@@ -39,7 +37,6 @@ jobs:
       run: aws s3 cp ./playwright-report s3://playwright-reports/uikit/pulls/${{ github.event.pull_request.number }}/ --endpoint-url=https://storage.yandexcloud.net --recursive
       shell: bash 
     - name: Create Comment
-      if: always()
       uses: marocchino/sticky-pull-request-comment@v2
       with:
         GITHUB_TOKEN: ${{ secrets.GRAVITY_UI_BOT_GITHUB_TOKEN }}

diff --git a/playwright/README.md b/playwright/README.md
@@ -3,9 +3,8 @@
 ## How to write a test
 
 1. Select the component you want to write tests for
-2. Inside the component folder, create the `__tests__` folder
-3. Create a file inside it with the following name `<ComponentName>.visual.test.tsx`
-4. Writing a test::
+2. Inside the component folder, create the `__tests__` folder and create a file inside it with the following name `<ComponentName>.visual.test.tsx`
+3. Writing a test:
 
    ```ts
    import React from 'react';
@@ -36,7 +35,7 @@ test.describe('Name group tests', () => {
 });
 ````
 
-5. Run tests
+4. Run tests
 
    ```shell
    npm run playwright:install
@@ -51,7 +50,7 @@ test.describe('Name group tests', () => {
 
    > `npm run playwright:install` command must be run only once on initial setup
 
-6. Update screenshots if needed
+5. Update screenshots if needed
 
 ```shell
  npm run playwright:update

diff --git a/playwright/playwright.config.ts b/playwright/playwright.config.ts
@@ -26,7 +26,7 @@ reporter.push(
  */
 const config: PlaywrightTestConfig = {
     testDir: pathFromRoot('src'),
-    testMatch: '*/__tests__/*.visual.test.tsx',
+    testMatch: '**/__tests__/*.visual.test.tsx',
     updateSnapshots: process.env.UPDATE_REQUEST ? 'all' : 'missing',
     snapshotPathTemplate:
         '{testDir}/{testFileDir}/../__snapshots__/{testFileName}-snapshots/{arg}{-projectName}-linux{ext}',

diff --git a/...Button.visual.test.tsx-snapshots/Button-ButtonViewShowcase-1-chromium-linux.png b/...Button.visual.test.tsx-snapshots/Button-ButtonViewShowcase-1-chromium-linux.png
diff --git a/..._/Button.visual.test.tsx-snapshots/Button-ButtonViewShowcase-1-webkit-linux.png b/..._/Button.visual.test.tsx-snapshots/Button-ButtonViewShowcase-1-webkit-linux.png
diff --git a/...pshots__/Button.visual.test.tsx-snapshots/Button-add-style-1-chromium-linux.png b/...pshots__/Button.visual.test.tsx-snapshots/Button-add-style-1-chromium-linux.png
diff --git a/...napshots__/Button.visual.test.tsx-snapshots/Button-add-style-1-webkit-linux.png b/...napshots__/Button.visual.test.tsx-snapshots/Button-add-style-1-webkit-linux.png
diff --git a/...x-snapshots/Button-loading-when-loading-true-prop-is-given-1-chromium-linux.png b/...x-snapshots/Button-loading-when-loading-true-prop-is-given-1-chromium-linux.png
diff --git a/...tsx-snapshots/Button-loading-when-loading-true-prop-is-given-1-webkit-linux.png b/...tsx-snapshots/Button-loading-when-loading-true-prop-is-given-1-webkit-linux.png
diff --git a/....visual.test.tsx-snapshots/Button-render-buttom-by-default-1-chromium-linux.png b/....visual.test.tsx-snapshots/Button-render-buttom-by-default-1-chromium-linux.png
diff --git a/...on.visual.test.tsx-snapshots/Button-render-buttom-by-default-1-webkit-linux.png b/...on.visual.test.tsx-snapshots/Button-render-buttom-by-default-1-webkit-linux.png
diff --git a/...ual.test.tsx-snapshots/Button-render-with-given-reset-type-1-chromium-linux.png b/...ual.test.tsx-snapshots/Button-render-with-given-reset-type-1-chromium-linux.png
diff --git a/...isual.test.tsx-snapshots/Button-render-with-given-reset-type-1-webkit-linux.png b/...isual.test.tsx-snapshots/Button-render-with-given-reset-type-1-webkit-linux.png
diff --git a/...al.test.tsx-snapshots/Button-render-with-given-submit-type-1-chromium-linux.png b/...al.test.tsx-snapshots/Button-render-with-given-submit-type-1-chromium-linux.png
diff --git a/...sual.test.tsx-snapshots/Button-render-with-given-submit-type-1-webkit-linux.png b/...sual.test.tsx-snapshots/Button-render-with-given-submit-type-1-webkit-linux.png
diff --git a/...snapshots/Button-selected-when-selected-true-prop-is-given-1-chromium-linux.png b/...snapshots/Button-selected-when-selected-true-prop-is-given-1-chromium-linux.png
diff --git a/...x-snapshots/Button-selected-when-selected-true-prop-is-given-1-webkit-linux.png b/...x-snapshots/Button-selected-when-selected-true-prop-is-given-1-webkit-linux.png
diff --git a/...ual.test.tsx-snapshots/Button-should-render-Icon-component-1-chromium-linux.png b/...ual.test.tsx-snapshots/Button-should-render-Icon-component-1-chromium-linux.png
diff --git a/...isual.test.tsx-snapshots/Button-should-render-Icon-component-1-webkit-linux.png b/...isual.test.tsx-snapshots/Button-should-render-Icon-component-1-webkit-linux.png
diff --git a/...utton.visual.test.tsx-snapshots/Button-should-render-a-tag-1-chromium-linux.png b/...utton.visual.test.tsx-snapshots/Button-should-render-a-tag-1-chromium-linux.png
diff --git a/.../Button.visual.test.tsx-snapshots/Button-should-render-a-tag-1-webkit-linux.png b/.../Button.visual.test.tsx-snapshots/Button-should-render-a-tag-1-webkit-linux.png
diff --git a/...Button.visual.test.tsx-snapshots/Button-should-render-icon-1-chromium-linux.png b/...Button.visual.test.tsx-snapshots/Button-should-render-icon-1-chromium-linux.png
diff --git a/..._/Button.visual.test.tsx-snapshots/Button-should-render-icon-1-webkit-linux.png b/..._/Button.visual.test.tsx-snapshots/Button-should-render-icon-1-webkit-linux.png
diff --git a/...est.tsx-snapshots/Button-should-render-icon-in-Button-Icon-1-chromium-linux.png b/...est.tsx-snapshots/Button-should-render-icon-in-Button-Icon-1-chromium-linux.png
diff --git a/....test.tsx-snapshots/Button-should-render-icon-in-Button-Icon-1-webkit-linux.png b/....test.tsx-snapshots/Button-should-render-icon-in-Button-Icon-1-webkit-linux.png
diff --git a/...utton.visual.test.tsx-snapshots/Button-show-given-children-1-chromium-linux.png b/...utton.visual.test.tsx-snapshots/Button-show-given-children-1-chromium-linux.png
diff --git a/.../Button.visual.test.tsx-snapshots/Button-show-given-children-1-webkit-linux.png b/.../Button.visual.test.tsx-snapshots/Button-show-given-children-1-webkit-linux.png
diff --git a/...Button.visual.test.tsx-snapshots/Button-show-given-content-1-chromium-linux.png b/...Button.visual.test.tsx-snapshots/Button-show-given-content-1-chromium-linux.png
diff --git a/..._/Button.visual.test.tsx-snapshots/Button-show-given-content-1-webkit-linux.png b/..._/Button.visual.test.tsx-snapshots/Button-show-given-content-1-webkit-linux.png