feat: add hook useOnClickOutside #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
NikitaCG
changed the title
amje
requested changes
Sep 13, 2023
NikitaCG
force-pushed
the
feat/add-use-on-click-outside
branch
from
9b83c41 to
9d53847
Compare
amje
requested changes
Sep 14, 2023
| }; | ||
|
|
||
| window.addEventListener('click', callback, {capture: true}); | ||
| window.addEventListener('touchstart', callback, {capture: true}); |
There was a problem hiding this comment.
Shouldn't it be touchend event?
There was a problem hiding this comment.
It depends on how we decide. I assumed that we need a callback to be triggered as soon as the user touches another place. If you set touchend, it will work only when the user releases his finger, it may take some time before that
There was a problem hiding this comment.
But we use click event not mousedown (click happens after mouseup), there should be some consistency
NikitaCG
force-pushed
the
feat/add-use-on-click-outside
branch
2 times, most recently
from
0442647 to
4380d3c
Compare
amje
requested changes
Sep 15, 2023
NikitaCG
force-pushed
the
feat/add-use-on-click-outside
branch
from
4380d3c to
2e9b118
Compare
amje
requested changes
Sep 18, 2023
| }; | ||
|
|
||
| window.addEventListener('mousedown', callback, {capture: true}); | ||
| window.addEventListener('touchend', callback, {capture: true}); |
There was a problem hiding this comment.
We should be consistent here, mousedown and touchstart or mouseup and touchend
NikitaCG
force-pushed
the
feat/add-use-on-click-outside
branch
from
3d2f4fa to
ec50e1a
Compare
amje
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.