feat(withTableSorting): add control the use of data sorting #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValeraS
requested changes
Oct 2, 2023
zzzorgo
force-pushed
the
table-fix-sorting-controoled
branch
from
e93954b to
3d2319d
Compare
|
@ValeraS Pushed the change in accord with your comment |
|
Preview is ready. |
ValeraS
requested changes
Oct 3, 2023
| @@ -28,6 +28,7 @@ export interface WithTableSortingProps { | |||
| defaultSortState?: SortState; | |||
| sortState?: SortState; | |||
| onSortStateChange?: (sortState: SortState) => void; | |||
| useExternalSorting?: boolean; | |||
There was a problem hiding this comment.
Let's rename to
Suggested change
| useExternalSorting?: boolean; | |
| disableDataSorting?: boolean; |
zzzorgo
force-pushed
the
table-fix-sorting-controoled
branch
from
3d2319d to
4c16983
Compare
zzzorgo
force-pushed
the
table-fix-sorting-controoled
branch
from
4c16983 to
32af455
Compare
zzzorgo
force-pushed
the
table-fix-sorting-controoled
branch
from
32af455 to
8cee379
Compare
ValeraS
approved these changes
Oct 4, 2023
ValeraS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
isControlledState()in this HOC is for determining whether thesortStateis provided externally or not. It shouldn't turn off the whole sorting as it does in this case making the whole HOC useless.