refactor: private hooks directory #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaCG
requested review from
amje,
ogonkov,
korvin89,
zamkovskaya,
kseniya57,
axtk and
ValeraS
as code owners
Closed
|
Preview is ready. |
NikitaCG
force-pushed
the
refactor/private-hooks
branch
from
152d969 to
10b8975
Compare
NikitaCG
changed the title
amje
requested changes
Nov 7, 2023
| @@ -0,0 +1,26 @@ | |||
| # useCheckbox | |||
|
|
|||
| The `useCheckbox` hook need to generate props for radio group element | |||
There was a problem hiding this comment.
radio group element -> checkbox control
|
|
||
| ## Result | ||
|
|
||
| - checked, radio-input status `boolean` |
There was a problem hiding this comment.
Let's use md table here, checked - Checked state, inputProps - Props to pass to the input element
| ## Result | ||
|
|
||
| - onMouseOver, `React.MouseEventHandler` | ||
| - onMouseLeave, `React.MouseEventHandler` |
src/hooks/private/useRadio/README.md
Outdated
| @@ -0,0 +1,25 @@ | |||
| # useRadio | |||
|
|
|||
| The `useRadio` hook need to generate props for radio group element | |||
src/hooks/private/useRadio/README.md
Outdated
| ## Result | ||
|
|
||
| - checked, radio-input status `boolean` | ||
| - inputProps |
| @@ -0,0 +1,22 @@ | |||
| # useRadioGroup | |||
|
|
|||
| The `useRadioGroup` hook need to generate props for radio group element | |||
| ## Result | ||
|
|
||
| - containerProps | ||
| - optionsProps |
|
|
||
| ## Result | ||
|
|
||
| - onFocus, `(event: React.FocusEvent) => void` |
| ## Result | ||
|
|
||
| - state, `any` | ||
| - setWithCallback, `(nextValue: T | ((value: T) => T)) => void` |
NikitaCG
force-pushed
the
refactor/private-hooks
branch
from
10b8975 to
82f6ddc
Compare
amje
approved these changes
Nov 8, 2023
korvin89
approved these changes
Nov 9, 2023
kseniya57
reviewed
Nov 9, 2023
| export * from './useBoolean'; | ||
| export * from './useCheckbox'; | ||
| export * from './useCloseOnTimeout'; | ||
| export * from './useConditionallyControlledState'; |
There was a problem hiding this comment.
Why is this private hook? It's general, it can be used by any app.
There was a problem hiding this comment.
it was not exported outside
There was a problem hiding this comment.
Ok ✅
Seems like it will be good to make it public.
NikitaCG
force-pushed
the
refactor/private-hooks
branch
from
82f6ddc to
25d4164
Compare
kseniya57
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.