feat(useAsyncActionHandler): add useAsyncActionHandler hook #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
korvin89
reviewed
Nov 7, 2023
| @@ -0,0 +1,30 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export function useAsyncActionHandler<Result>( | |||
There was a problem hiding this comment.
- What is
Result? There is no such type in the current namespace - It is not convenient to have generic with а required parameter
amje
requested changes
Nov 7, 2023
| @@ -0,0 +1,30 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export function useAsyncActionHandler<Result>( | |||
There was a problem hiding this comment.
Let's follow this convention #881
| [action], | ||
| ); | ||
|
|
||
| return [isLoading, handleAction]; |
There was a problem hiding this comment.
I would change to object here: {isLoading, handler}. Tuples are primary used for [value, setValue]
| const handleAction: typeof action = React.useCallback( | ||
| (...args) => { | ||
| setLoading(true); | ||
| return action(...args).finally(() => { |
There was a problem hiding this comment.
Let's add check if returned value is a promise before calling finally
kseniya57
force-pushed
the
async-action-handler-hook
branch
from
815b4e7 to
6313ddb
Compare
korvin89
approved these changes
Nov 8, 2023
amje
approved these changes
Nov 8, 2023
ValeraS
requested changes
Nov 8, 2023
kseniya57
force-pushed
the
async-action-handler-hook
branch
from
6313ddb to
dc9575e
Compare
|
@ValeraS ping |
ValeraS
requested changes
Nov 12, 2023
ValeraS
requested changes
Nov 14, 2023
kseniya57
force-pushed
the
async-action-handler-hook
branch
from
dc9575e to
a4ccbfa
Compare
ValeraS
approved these changes
Nov 14, 2023
kseniya57
force-pushed
the
async-action-handler-hook
branch
from
a4ccbfa to
52de79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.