feat(Text): support multiline and fixed width ellipsis #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
amje
changed the title
Text component
amje
requested changes
Nov 14, 2023
amje
reviewed
Nov 14, 2023
IsaevAlexandr
force-pushed
the
feature/text-elipsis
branch
from
01df15c to
c5487b0
Compare
amje
requested changes
Nov 21, 2023
IsaevAlexandr
force-pushed
the
feature/text-elipsis
branch
from
c5487b0 to
727b3d4
Compare
|
/fixed |
amje
requested changes
Dec 4, 2023
src/components/Text/text/text.ts
Outdated
| @@ -71,6 +71,13 @@ export interface TextBaseProps { | |||
| * - text-overflow: ellipsis; | |||
| */ | |||
| ellipsis?: boolean; | |||
| /** | |||
| * The number of whole lines of text after which the content will be cut off. | |||
IsaevAlexandr
requested review from
resure,
ogonkov,
sofiushko,
Raubzeug,
zamkovskaya,
SeqviriouM,
mournfulCoroner,
DaffPunks,
Lunory,
kseniya57,
jhoncool,
NikitaCG,
LakeVostok,
goshander,
axtk and
ValeraS
as code owners
IsaevAlexandr
force-pushed
the
feature/text-elipsis
branch
from
727b3d4 to
f536352
Compare
amje
approved these changes
Dec 11, 2023
IsaevAlexandr
force-pushed
the
feature/text-elipsis
branch
from
f536352 to
fd55499
Compare
ogonkov
reviewed
Dec 11, 2023
| }; | ||
|
|
||
| if (typeof ellipsisLines === 'number') { | ||
| style.WebkitLineClamp = ellipsisLines; |
There was a problem hiding this comment.
What the point to use inline style, and not modifier in stylesheet?
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.